Closed Bug 1456430 Opened Last year Closed Last year

the blue focus ring in the netmonitor's filter is inconsistent with the console's

Categories

(DevTools :: Netmonitor, defect, P2)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: pbro, Assigned: Honza)

References

Details

Attachments

(4 files)

Steps:
- open Nightly
- open the netmonitor
- click inside the filter input bar --> notice the focus blue outline is displayed
- now switch to the console
- click inside the filter input bar --> notice the focus blue outline there too

Bug: the 2 outlines are different. The console one (which I think is the right one here) is displayed along the borders of the field. The netmonitor one instead, is displayed with some padding, inside the field.

See the 2 screenshots for comparison.
Has STR: --- → yes
Priority: -- → P2
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Attached image focus-ring.png
Here is a screenshot showing how the focus ring looks like on my win machine after applying the patch.

Honza
Comment on attachment 8971498 [details]
Bug 1456430 - Fix search box focus ring;

https://reviewboard.mozilla.org/r/240264/#review246236
Attachment #8971498 - Flags: review?(dwalsh) → review+
Thanks for the review David!

Honza
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d256e50b2bf8
Fix search box focus ring; r=davidwalsh
https://hg.mozilla.org/mozilla-central/rev/d256e50b2bf8
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.