1456430 - the blue focus ring in the netmonitor's filter is inconsistent with the console's

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Patrick Brosset <:pbro>]

Attachment: console-blue-outline.PNG

Steps:
- open Nightly
- open the netmonitor
- click inside the filter input bar --> notice the focus blue outline is displayed
- now switch to the console
- click inside the filter input bar --> notice the focus blue outline there too

Bug: the 2 outlines are different. The console one (which I think is the right one here) is displayed along the borders of the field. The netmonitor one instead, is displayed with some padding, inside the field.

See the 2 screenshots for comparison.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: network-blue-outline.PNG

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1456430 - Fix search box focus ring;

Review commit: https://reviewboard.mozilla.org/r/240264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240264/

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: focus-ring.png

Here is a screenshot showing how the focus ring looks like on my win machine after applying the patch.

Honza

Comment 4

[David Walsh :davidwalsh]

Comment on attachment 8971498 [details]
Bug 1456430 - Fix search box focus ring;

https://reviewboard.mozilla.org/r/240264/#review246236

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the review David!

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d256e50b2bf8
Fix search box focus ring; r=davidwalsh

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d256e50b2bf8