Closed
Bug 1456450
Opened 6 years ago
Closed 6 years ago
Sort Marionette JAR manifest
Categories
(Remote Protocol :: Marionette, enhancement)
Remote Protocol
Marionette
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(1 file)
Appending to bottom of testing/marionette/jar.mn causes endless merge conflicts.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8970514 [details] Bug 1456450 - Sort marionette.jar manifest lexicographically. https://reviewboard.mozilla.org/r/239284/#review244966 ::: testing/marionette/jar.mn:47 (Diff revision 1) > + content/test_anonymous_content.xul (chrome/test_anonymous_content.xul) > content/test_dialog.dtd (chrome/test_dialog.dtd) > content/test_dialog.properties (chrome/test_dialog.properties) > content/test_dialog.xul (chrome/test_dialog.xul) > content/test_nested_iframe.xul (chrome/test_nested_iframe.xul) > - content/test_anonymous_content.xul (chrome/test_anonymous_content.xul) > + content/test.xul (chrome/test.xul) Why this isn't next to test2.xul anymore? Because '.' is treated as after '_' and numbers and chars? Feels awkward here.
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8970514 [details] Bug 1456450 - Sort marionette.jar manifest lexicographically. https://reviewboard.mozilla.org/r/239284/#review244966 > Why this isn't next to test2.xul anymore? Because '.' is treated as after '_' and numbers and chars? Feels awkward here. Because it is sorted in lexicographical order, and . has a lower octal code (056) than _ (137). See sort(1) and locale(1).
Comment 4•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8970514 [details] Bug 1456450 - Sort marionette.jar manifest lexicographically. https://reviewboard.mozilla.org/r/239284/#review244966 > Because it is sorted in lexicographical order, and . has a lower > octal code (056) than _ (137). See sort(1) and locale(1). If we go by automatic sorting then fine.
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8970514 [details] Bug 1456450 - Sort marionette.jar manifest lexicographically. https://reviewboard.mozilla.org/r/239284/#review244982
Attachment #8970514 -
Flags: review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8970514 [details] Bug 1456450 - Sort marionette.jar manifest lexicographically. https://reviewboard.mozilla.org/r/239284/#review245010
Attachment #8970514 -
Flags: review?(mjzffr) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7a9b9ce05f85 Sort marionette.jar manifest lexicographically. r=maja_zf,whimboo
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7a9b9ce05f85
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•