1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar()

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Toplevel GdkWindow is re-created at nsWindow::SetDrawsInTitlebar() we also need to set correct window attributes as we do at nsWindow::Create().

It means to set _NET_WM_BYPASS_COMPOSITOR and gdk_window_set_role()/XSetClassHint.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(),

Implement SetCompositorHint() which sets _NET_WM_BYPASS_COMPOSITOR GtkWindow property when it's recreated
at nsWindow::SetDrawsInTitlebar().

Window role/class is handled by nsWindow::RefreshWindowClass(), it uses stored window class
passed to nsWindow::SetWindowClass().

Also set "nsWindow" data property to new mGdkWindow as we do at nsWindow::Create().

Review commit: https://reviewboard.mozilla.org/r/239632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239632/

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8970850 [details]
Bug 1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(),

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239632/diff/1-2/

Comment 3

[Jan Horak [:jhorak]]

Comment on attachment 8970850 [details]
Bug 1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(),

https://reviewboard.mozilla.org/r/239632/#review249166

::: commit-message-6eeb9:9
(Diff revision 2)
> +at nsWindow::SetDrawsInTitlebar().
> +
> +Window role/class is handled by nsWindow::RefreshWindowClass(), it uses stored window class
> +passed to nsWindow::SetWindowClass().
> +
> +Also set "nsWindow" data property to new mGdkWindow as we do at nsWindow::Create().

Are you sure? I don't see any touching mGdkWindow in the code.

::: widget/gtk/nsWindow.h:492
(Diff revision 2)
> +                   GTK_WIDGET_COMPOSIDED_ENABLED = 2
> +    } WindowComposeRequest;
> +
> +    void                SetCompositorHint(WindowComposeRequest aState);
> +#endif
> +    char               *mGtkWindowTypeName;

I guess you're leaking mGtkWindowTypeName when window is closed/destroyed.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8970850 [details]
Bug 1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(),

https://reviewboard.mozilla.org/r/239632/#review249174

::: commit-message-6eeb9:9
(Diff revision 2)
> +at nsWindow::SetDrawsInTitlebar().
> +
> +Window role/class is handled by nsWindow::RefreshWindowClass(), it uses stored window class
> +passed to nsWindow::SetWindowClass().
> +
> +Also set "nsWindow" data property to new mGdkWindow as we do at nsWindow::Create().

You're right, that's already checked in.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8970850 [details]
Bug 1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(),

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239632/diff/2-3/

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8970850 [details]
Bug 1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(),

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239632/diff/3-4/

Comment 7

[Jan Horak [:jhorak]]

Comment on attachment 8970850 [details]
Bug 1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(),

https://reviewboard.mozilla.org/r/239632/#review249510

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b44a1b57b301
[CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(), r=jhorak

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b44a1b57b301

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this something that needs uplift consideration for 61, or can it ride the trains?

Comment 11

[Martin Stránský [:stransky] (ni? me)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)
> Is this something that needs uplift consideration for 61, or can it ride the
> trains?

Yes, it may be uplifted after some testing time at nightly.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta (and ESR60?) approval if this has baked long enough.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8970850 [details]
Bug 1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(),

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1283299
[User impact if declined]: Various Gtk+/system integration issues (missing/misplaced mouse clicks, missing Firefox window grouping and so on)
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: Not risky, it reuses an existing code and applies it to newly created GtkWindow. 
[String changes made/needed]: none

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8970850 [details]
Bug 1456451 - [CSD] Update toplevel GdkWindow property when it's recreated at nsWindow::SetDrawsInTitlebar(),

Fixes various window issues with tabs in the titlebar enabled on Linux. Approved for 61.0b10.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/982e4bff688a