Closed Bug 1456470 Opened Last year Closed Last year

ARM backend: mark a few padding fields as protected to avoid compiler warnings

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

Details

Attachments

(1 file)

Attached patch unused.patchSplinter Review
I get these compiler warnings with clang version 6.0.1, and they seem legit. Applied the regular workaround.
Attachment #8970532 - Flags: review?(mgaudet)
I even wonder if we can't just remove those fields... They might be meaningful when we're reinterpreting bits from the assembler stream as structures, but I don't even know if they're used that way.
Comment on attachment 8970532 [details] [diff] [review]
unused.patch

Review of attachment 8970532 [details] [diff] [review]:
-----------------------------------------------------------------

As far as addressing the unused variable warnings, looks good to me. 

I have other questions about how this padding gets dealt with / initialized, and a minor concern about RRS::mustZero_ being unused, but not enough to say anything but r+ here.
Attachment #8970532 - Flags: review?(mgaudet) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1ea9ba622e6
Mark a few fields as protected in ARM classes to avoid unused private fields warnings; r=mgaudet
Thanks for the review! A try build [1] seems to agree that we can remove those fields, but I'd rather have somebody do a manual audit to confirm first.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc1449ab94dfb7c5f8e3fddea706ee9867a39f1a
https://hg.mozilla.org/mozilla-central/rev/a1ea9ba622e6
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.