Closed Bug 1456552 Opened 3 years ago Closed 3 years ago

MOZ_OPTIMIZE_FLAGS is not set for MinGW Build

Categories

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

3 Branch
enhancement

Tracking

(firefox-esr60 fixed, firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr60 --- fixed
firefox62 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(1 file)

Someone told me we don't set MOZ_OPTIMIZE_FLAGS in the gcc block for Windows; resulting to a fall-through case where we use -O.  It seems like we can do better than that, and should be using O1 at least; or maybe Os or O2.
Attachment #8974762 - Flags: review?(core-build-config-reviews) → review?(ted)
Comment on attachment 8974762 [details]
Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O

https://reviewboard.mozilla.org/r/243156/#review251494
Attachment #8974762 - Flags: review?(ted) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/87f1c846afc3
Make Optimized MinGW builds use -O# instead of falling through and collecting a -O r=ted
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/87f1c846afc3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment on attachment 8974762 [details]
Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O

[Approval Request Comment]

This is one of several MinGW Build patches we'd like to land in esr60 for Tor.
It will prevent us from carrying our own patches for the lifetime of esr60
and will enable Mozilla to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8974762 - Flags: approval-mozilla-esr60?
Comment on attachment 8974762 [details]
Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O

use -O1 on mingw, approved for 60.1esr
Attachment #8974762 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Version: Version 3 → 3 Branch
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.