1456552 - MOZ_OPTIMIZE_FLAGS is not set for MinGW Build

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Description

[Tom Ritter [:tjr]]

Someone told me we don't set MOZ_OPTIMIZE_FLAGS in the gcc block for Windows; resulting to a fall-through case where we use -O.  It seems like we can do better than that, and should be using O1 at least; or maybe Os or O2.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O

Review commit: https://reviewboard.mozilla.org/r/243156/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243156/

Comment 2

[Tom Ritter [:tjr]]

Comment on attachment 8974762 [details]
Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243156/diff/1-2/

Comment 3

[Tom Ritter [:tjr]]

Comment on attachment 8974762 [details]
Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243156/diff/2-3/

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8974762 [details]
Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O

https://reviewboard.mozilla.org/r/243156/#review251494

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87f1c846afc3
Make Optimized MinGW builds use -O# instead of falling through and collecting a -O r=ted

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/87f1c846afc3

Comment 7

[Georg Koppen]

Comment on attachment 8974762 [details]
Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O

[Approval Request Comment]

This is one of several MinGW Build patches we'd like to land in esr60 for Tor.
It will prevent us from carrying our own patches for the lifetime of esr60
and will enable Mozilla to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8974762 [details]
Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O

use -O1 on mingw, approved for 60.1esr

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/1b10610a4e89