1456591 - accesskey underline style leak from minimal-xul.css to web content

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. Click on the URL

data:text/html,<span class="accesskey">hello</span>

Expected: no underline

Actual: underline

The style was added onto xul.css back in bug 68841. Can this bug be 14yo without people finding it? Really?

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug can be easily "fixed" by changing the selector to `label > html|span.accesskey`. 

I however wonder if the entire sheet can be detected by web content if the site attempt to serve an xHTML document with XUL in it like https://stackoverflow.com/a/1588407 . Do we block that?

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1456591 - Underline only the accesskey in XUL UI

Review commit: https://reviewboard.mozilla.org/r/239722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239722/

Comment 3

[Neil Deakin]

Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

https://reviewboard.mozilla.org/r/239722/#review245484

Can it not use '>'? in the selector? Or, if this is only set in one place (text.xml) perhaps we should just set text-decoration directly instead of setting a class.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

https://reviewboard.mozilla.org/r/239722/#review245488

It is actually

```
<xul:label>Restore previous session<html:span anonid="accessKeyParens"> (<html:span class="accesskey">S</html:span>)</html:span></xul:label>
```

when XBL is applied.

I would like to avoid inline style.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

https://reviewboard.mozilla.org/r/239722/#review245488

So, perhaps `label > span > span.accesskey`?

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

https://reviewboard.mozilla.org/r/239722/#review245488

Oh, if `intl.menuitems.alwaysappendaccesskeys` is not `true`, you'd get

```
<xul:label>Re<span class="accesskey">s</span>tore previous session</xul:label>
```

So we can't use the selector I've just said...

Comment 7

[Neil Deakin]

Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

Ok then. In the long run, we should probably switch accesskey rendering to use a new selection type instead.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/583940ed5be7
Underline only the accesskey in XUL UI. r=enndeakin+6102

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/583940ed5be7

Comment 10

[Md Maruf Rahman]

I have reproduced this bug with Nightly 61.0a1 (2018-04-24) on Windows 10, 64 Bit!
This bug's fix is verified with latest Beta!

Build ID 	20180528091514
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0