Closed Bug 1456591 Opened 2 years ago Closed 2 years ago

accesskey underline style leak from minimal-xul.css to web content

Categories

(Toolkit :: XUL Widgets, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

()

Details

Attachments

(1 file)

STR:

1. Click on the URL

data:text/html,<span class="accesskey">hello</span>

Expected: no underline

Actual: underline

The style was added onto xul.css back in bug 68841. Can this bug be 14yo without people finding it? Really?
This bug can be easily "fixed" by changing the selector to `label > html|span.accesskey`. 

I however wonder if the entire sheet can be detected by web content if the site attempt to serve an xHTML document with XUL in it like https://stackoverflow.com/a/1588407 . Do we block that?
Attachment #8970973 - Flags: review?(enndeakin)
Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

https://reviewboard.mozilla.org/r/239722/#review245484

Can it not use '>'? in the selector? Or, if this is only set in one place (text.xml) perhaps we should just set text-decoration directly instead of setting a class.
Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

https://reviewboard.mozilla.org/r/239722/#review245488

It is actually

```
<xul:label>Restore previous session<html:span anonid="accessKeyParens"> (<html:span class="accesskey">S</html:span>)</html:span></xul:label>
```

when XBL is applied.

I would like to avoid inline style.
Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

https://reviewboard.mozilla.org/r/239722/#review245488

So, perhaps `label > span > span.accesskey`?
Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

https://reviewboard.mozilla.org/r/239722/#review245488

Oh, if `intl.menuitems.alwaysappendaccesskeys` is not `true`, you'd get

```
<xul:label>Re<span class="accesskey">s</span>tore previous session</xul:label>
```

So we can't use the selector I've just said...
Priority: -- → P3
Comment on attachment 8970973 [details]
Bug 1456591 - Underline only the accesskey in XUL UI

Ok then. In the long run, we should probably switch accesskey rendering to use a new selection type instead.
Attachment #8970973 - Flags: review?(enndeakin) → review+
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/583940ed5be7
Underline only the accesskey in XUL UI. r=enndeakin+6102
https://hg.mozilla.org/mozilla-central/rev/583940ed5be7
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
QA Whiteboard: [good first verify]
I have reproduced this bug with Nightly 61.0a1 (2018-04-24) on Windows 10, 64 Bit!
This bug's fix is verified with latest Beta!

Build ID 	20180528091514
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
QA Whiteboard: [good first verify] → [good first verify] [bugday-20180613]
You need to log in before you can comment on or make changes to this bug.