Closed
Bug 1456602
Opened 6 years ago
Closed 6 years ago
Let tab warming ride to release for Windows and Linux
Categories
(Firefox :: Tabbed Browser, enhancement, P1)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 61
People
(Reporter: mconley, Assigned: mconley)
References
(Depends on 1 open bug)
Details
(Keywords: feature)
Attachments
(1 file)
Bug 1453080 seems sufficiently troublesome enough that I think it makes sense to hold off on riding the trains for macOS for now. But I think Windows and Linux should be okay.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mconley
Updated•6 years ago
|
Priority: -- → P1
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•6 years ago
|
||
I'm aware that I could have made that a single conditional, but I thought this would be more readable.
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8970960 [details] Bug 1456602 - Enable tab warming for Windows and Linux on all channels. https://reviewboard.mozilla.org/r/239716/#review245416
Attachment #8970960 -
Flags: review?(florian) → review+
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/821119f7069d Enable tab warming for Windows and Linux on all channels. r=florian
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/821119f7069d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Assignee | ||
Comment 6•6 years ago
|
||
Release Note Request (optional, but appreciated) [Why is this notable]: Should provide a tab switch performance boost for our Desktop users on Windows and Linux when they're using the mouse to select tabs (since we're pre-emptively rendering tabs when hovering them). [Affects Firefox for Android]: No. [Suggested wording]: Faster tab switching in the majority of cases for our Windows and Linux users. [Links (documentation, blog post, etc)]: https://mikeconley.ca/blog/2018/01/11/making-tab-switching-faster-in-firefox-with-tab-warming/
relnote-firefox:
--- → ?
Updated•6 years ago
|
Comment on attachment 8970960 [details] Bug 1456602 - Enable tab warming for Windows and Linux on all channels. https://reviewboard.mozilla.org/r/239716/#review246254 ::: browser/app/profile/firefox.js:1542 (Diff revision 1) > +// on all channels. > +// > +// This feature is enabled on macOS only on the Nightly channel > +// until bug 1453080 is fixed. > +// > +#if defined(XP_LINUX) || defined(XP_WIN) Better replace `XP_LINUX` with `MOZ_WIDGET_GTK` unless you intentionally want to exclude Tier3 platforms like DragonFly, FreeBSD, OpenBSD, NetBSD, Solaris.
You need to log in
before you can comment on or make changes to this bug.
Description
•