1456602 - Let tab warming ride to release for Windows and Linux

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1453080 seems sufficiently troublesome enough that I think it makes sense to hold off on riding the trains for macOS for now. But I think Windows and Linux should be okay.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1456602 - Enable tab warming for Windows and Linux on all channels.

Review commit: https://reviewboard.mozilla.org/r/239716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239716/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I'm aware that I could have made that a single conditional, but I thought this would be more readable.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8970960 [details]
Bug 1456602 - Enable tab warming for Windows and Linux on all channels.

https://reviewboard.mozilla.org/r/239716/#review245416

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/821119f7069d
Enable tab warming for Windows and Linux on all channels. r=florian

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/821119f7069d

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Release Note Request (optional, but appreciated)
[Why is this notable]:

Should provide a tab switch performance boost for our Desktop users on Windows and Linux when they're using the mouse to select tabs (since we're pre-emptively rendering tabs when hovering them).

[Affects Firefox for Android]:

No.

[Suggested wording]:

Faster tab switching in the majority of cases for our Windows and Linux users.

[Links (documentation, blog post, etc)]:

https://mikeconley.ca/blog/2018/01/11/making-tab-switching-faster-in-firefox-with-tab-warming/

Comment 7

[Jan Beich]

Comment on attachment 8970960 [details]
Bug 1456602 - Enable tab warming for Windows and Linux on all channels.

https://reviewboard.mozilla.org/r/239716/#review246254

::: browser/app/profile/firefox.js:1542
(Diff revision 1)
> +// on all channels.
> +//
> +// This feature is enabled on macOS only on the Nightly channel
> +// until bug 1453080 is fixed.
> +//
> +#if defined(XP_LINUX) || defined(XP_WIN)

Better replace `XP_LINUX` with `MOZ_WIDGET_GTK` unless you intentionally want to exclude Tier3 platforms like DragonFly, FreeBSD, OpenBSD, NetBSD, Solaris.