Closed
Bug 1456620
Opened 6 years ago
Closed 6 years ago
partner followups - chunk mac signing, stop uploading public partners to private
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
Attachments
(3 files)
This isn't all of the partner repack followups, but it's the part I have ready at the moment :)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8970699 [details] bug 1456620 - stop uploading public partners to private. https://reviewboard.mozilla.org/r/239442/#review245524
Attachment #8970699 -
Flags: review?(nthomas) → review+
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8970700 [details] bug 1456620 - move check_if_partners_enabled call. https://reviewboard.mozilla.org/r/239444/#review245522 Did you consider moving the check in the other transforms that use it ?
Attachment #8970700 -
Flags: review?(nthomas) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8970701 [details] bug 1456620 - chunk mac partner signing. https://reviewboard.mozilla.org/r/239446/#review245520 Nice! ::: taskcluster/ci/release-partner-repack-signing/kind.yml:25 (Diff revision 1) > > job-template: > shipping-product: firefox > shipping-phase: promote > depname: release-partner-repack > max-run-time: 7200 We could revert this to 3600 now, as well as backout https://hg.mozilla.org/build/puppet/rev/df684936db26. ::: taskcluster/taskgraph/transforms/signing.py:111 (Diff revision 1) > add_scope_prefix(config, 'signing:format:{}'.format(format)) > ) > > is_nightly = dep_job.attributes.get('nightly', False) > treeherder = None > - if 'partner' not in config.kind: > + if 'partner' not in config.kind and 'eme-free' not in config.kind: Was this a necessary change or 'while you were here' ? Would be good to know the motivation. There will be treeherder config in the eme-free kind.yml's that can be removed too.
Attachment #8970701 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 7•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8970701 [details] bug 1456620 - chunk mac partner signing. https://reviewboard.mozilla.org/r/239446/#review245520 > We could revert this to 3600 now, as well as backout https://hg.mozilla.org/build/puppet/rev/df684936db26. Nice, will do. > Was this a necessary change or 'while you were here' ? Would be good to know the motivation. There will be treeherder config in the eme-free kind.yml's that can be removed too. Yeah, I hit a treeherder unit test error and decided to just rip it out.
Assignee | ||
Comment 8•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8970700 [details] bug 1456620 - move check_if_partners_enabled call. https://reviewboard.mozilla.org/r/239444/#review245522 I did, but this was the only one breaking, so I think `meh` won out.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•6 years ago
|
||
Pushed by asasaki@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59551e6e74ff stop uploading public partners to private. r=nthomas https://hg.mozilla.org/integration/autoland/rev/05a13c9b1c3c move check_if_partners_enabled call. r=nthomas https://hg.mozilla.org/integration/autoland/rev/6f16b7871d60 chunk mac partner signing. r=nthomas
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/59551e6e74ff https://hg.mozilla.org/mozilla-central/rev/05a13c9b1c3c https://hg.mozilla.org/mozilla-central/rev/6f16b7871d60
You need to log in
before you can comment on or make changes to this bug.
Description
•