1456630 - Avoid main-thread IO creating SystemInfo when starting up GMP service

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

Extracted from bug 1363586.

Relevant profile: https://perf-html.io/public/b2110955e06d5e0477b65c7d3f4114cb311ce992/calltree/?search=nsSystemInfo%3A%3AInit&thread=0&threadOrder=0-2-3-4-5-6-7-8-1-9&v=3

We're getting the SystemInfo thing because we're checking to see that we're running Vista or newer here:

https://searchfox.org/mozilla-central/rev/36dec78aecc40539ecc8d78e91612e38810f963c/toolkit/modules/GMPUtils.jsm#60-62

Only Windows 7 and above is supported now, so I think we can safely swap out this check to just ensure that we're running Windows.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1456630 - Stop checking for Vista or earlier in GMPUtils, since those verisons of Windows aren't supported anymore.

This should help us avoid doing some main-thread IO during start-up, since we won't
need to init an nsSystemInfo object (which touches disk).

Review commit: https://reviewboard.mozilla.org/r/239454/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239454/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8970702 [details]
Bug 1456630 - Stop checking for Vista or earlier in GMPUtils, since those verisons of Windows aren't supported anymore.

https://reviewboard.mozilla.org/r/239454/#review245290

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/842b7bc6ad24
Stop checking for Vista or earlier in GMPUtils, since those verisons of Windows aren't supported anymore. r=cpearce

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/842b7bc6ad24