Closed Bug 1456630 Opened Last year Closed Last year

Avoid main-thread IO creating SystemInfo when starting up GMP service

Categories

(Core :: Audio/Video: GMP, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxperf])

Attachments

(1 file)

Extracted from bug 1363586.

Relevant profile: https://perf-html.io/public/b2110955e06d5e0477b65c7d3f4114cb311ce992/calltree/?search=nsSystemInfo%3A%3AInit&thread=0&threadOrder=0-2-3-4-5-6-7-8-1-9&v=3

We're getting the SystemInfo thing because we're checking to see that we're running Vista or newer here:

https://searchfox.org/mozilla-central/rev/36dec78aecc40539ecc8d78e91612e38810f963c/toolkit/modules/GMPUtils.jsm#60-62

Only Windows 7 and above is supported now, so I think we can safely swap out this check to just ensure that we're running Windows.
Comment on attachment 8970702 [details]
Bug 1456630 - Stop checking for Vista or earlier in GMPUtils, since those verisons of Windows aren't supported anymore.

https://reviewboard.mozilla.org/r/239454/#review245290
Attachment #8970702 - Flags: review?(cpearce) → review+
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/842b7bc6ad24
Stop checking for Vista or earlier in GMPUtils, since those verisons of Windows aren't supported anymore. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/842b7bc6ad24
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee: nobody → mconley
You need to log in before you can comment on or make changes to this bug.