1456664 - Right Oculus Touch Controller Axes Do Not Update When The Left Controller Is Off

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[[e-mail]]

Repro Steps :
Take battery out of left touch controller.
Query navigator.getGamepads to get the right touch controller.
The axes will not update.

Comment 1

[[e-mail]]

Note :
If you start with both batteries in the controllers, the right touch controller axes work.
Then, remove the battery from the left controller. The right controller will still work for a short while.
After 5-10 seconds, the right controller axes stop working again.

Comment 2

[[e-mail]]

This seems to be a bug at the browser level (not at the Oculus level) because the right controller's joystick works in Oculus Home even when the left controller is off.

Comment 3

[Daosheng Mu[:daoshengmu]]

There is a little mistake when getting Thumbstick value from InputState. We should use ovrHandType to fetch it instead of the index i.

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1456664 - Fix the right Oculus Touch axes no value issue when the left one is off;

Review commit: https://reviewboard.mozilla.org/r/246990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246990/

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8980813 [details]
Bug 1456664 - Fix the right Oculus Touch axes no value issue when the left one is off;

https://reviewboard.mozilla.org/r/246990/#review253100

Good find, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68a506acf664
Fix the right Oculus Touch axes no value issue when the left one is off; r=kip

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/68a506acf664