1456746 - Startup/Shutdown timeout for Firefox needs to be increased to 70s

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently the shutdown timeout for Firefox is set to 60s, which means the background hang monitor thread won't be able to kick in after 65s in case Firefox hangs during shutdown. As result we won't see a crash with stack of the hang.

https://dxr.mozilla.org/mozilla-central/rev/26e53729a10976f52e75efa44e17b5e054969fec/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py#143

We should consider to increase this timeout maybe to 70s. But then it would only work for opt and debug builds. ASAN builds have a delay of 180s.

So maybe we should take the pref `toolkit.asyncshutdown.crash_timeout` into account.

James would you be ok with just doing the first step for now? All of our hangs happen for opt/pgo builds, and I really would like to see more crash reports for such hangs.

Comment 1

[James Graham [:jgraham]]

Sure. Are you going to make a patch?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to James Graham [:jgraham] from comment #1)
> Sure. Are you going to make a patch?

Sorry, I completely missed your reply here. Yes, I can provide a patch for it.

I will also bump the startup timeout to 70s so that we are able to catch possible startup crashes + involved hangs of content processes.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1456746 - [wpt] Startup/Shutdown timeout for Firefox needs to be increased to 70s.

To catch possible crashes as triggered by the background hang
monitor the startup/shutdown timeouts for Firefox have to be
increased to 70s.

Review commit: https://reviewboard.mozilla.org/r/260934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260934/

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8996947 [details]
Bug 1456746 - [wpt] Startup/Shutdown timeout for Firefox needs to be increased to 70s.

https://reviewboard.mozilla.org/r/260934/#review267986

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc1ce2b7d82a
[wpt] Startup/Shutdown timeout for Firefox needs to be increased to 70s. r=jgraham

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12275 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bc1ce2b7d82a

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged