Remove mozillamessaging.com urls and update branding pref urls.

RESOLVED FIXED in Thunderbird 61.0

Status

defect
RESOLVED FIXED
Last year
Last year

People

(Reporter: sancus, Assigned: sancus)

Tracking

unspecified
Thunderbird 61.0

Thunderbird Tracking Flags

(thunderbird60 fixed, thunderbird61 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This bug is to remove mozillamessaging.com from all pref urls and also update some of the branding prefs that point at mozilla.org to point at thunderbird.net instead.

I've also added https in places where http was used, to improve security.

There are many, many other pref URLs that point directly to mozilla.org pages and services, unfortunately, but this is a start.
Posted patch bug1456767.patch (obsolete) — Splinter Review
Assignee: nobody → sancus
There are a few weird things in here like SurveyURL and AbortSurveyURL, which I'm not sure if we want to still use. Right now they point at dead surveys, but we could use them in the future by just changing the live redirects so I didn't remove them.

Also, I left URLInfoAbout pointing at mozilla.org because we are still using the Mozilla name in our branding and I'm not quite sure what it's used for so it seemed reasonable to leave a link in to Mozilla.
Removed one additional use of getthunderbird.com that I apparently missed.
Attachment #8970826 - Attachment is obsolete: true
Assignee

Updated

Last year
Attachment #8971109 - Flags: review?(jorgk)
Attachment #8971109 - Flags: approval-comm-beta?

Comment 4

Last year
Comment on attachment 8971109 [details] [diff] [review]
pref patch attempt #2

Review of attachment 8971109 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, first patch ;-) ?

Just one question, see below.

::: mail/branding/nightly/thunderbird-branding.js
@@ +18,5 @@
>  
>  // Give the user x seconds to react before showing the big UI. nightly=1 hour
>  pref("app.update.promptWaitTime", 3600);
>  
> +pref("app.vendorURL", "https://www.thunderbird.net/%LOCALE%/");

%APP% not needed here?

::: mail/branding/thunderbird/thunderbird-branding.js
@@ +14,5 @@
>  
>  // Give the user x seconds to react before showing the big UI. default=24 hours
>  pref("app.update.promptWaitTime", 86400);
>  
> +pref("app.vendorURL", "https://www.thunderbird.net/%LOCALE%/");

And here?
(In reply to Jorg K (GMT+1) from comment #4)
> Review of attachment 8971109 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice, first patch ;-) ?

Yep 12 years working on Mozilla stuff, on and off, and this is my first client patch haha.

> %APP% not needed here?

No, %APP% isn't needed in these places anymore because thunderbird.net is only for Thunderbird. It was there because mozilla.org was used for multiple applications and so there existed mozilla.org/firefox, mozilla.org/thunderbird, etc.
Oh, there are a few other places where %APP% is kept in and theoretically it could have been removed but I did keep /thunderbird/ in some URLs on the server side, mostly on release notes and system requirements.

Comment 7

Last year
(In reply to Andrei Hajdukewycz [:sancus] from comment #5)
> No, %APP% isn't needed in these places anymore because thunderbird.net is
> only for Thunderbird.
That's what I thought, however, you have %APP% in most other URLs, like:
https://live.thunderbird.net/%APP%/releasenotes?locale=%LOCALE%&version=%VERSION%&os=%OS%&buildid=%APPBUILDID%

So what's the motivation for that?

OK, mid-air collision, answered in previous comment.

Comment 8

Last year
Comment on attachment 8971109 [details] [diff] [review]
pref patch attempt #2

And all these new URLs work, yes?

What's the story with www.getthunderbird.com. We own that as well, right? But we just redirect to thunderbird.net?
Attachment #8971109 - Flags: review?(jorgk)
Attachment #8971109 - Flags: review+
Attachment #8971109 - Flags: approval-comm-beta?
Attachment #8971109 - Flags: approval-comm-beta+
(In reply to Jorg K (GMT+1) from comment #8)
> And all these new URLs work, yes?

I did test them all thoroughly, multiple times, yes. The ones that are just live.mozillamessaging.com -> live.thunderbird.net are the exact same since both domains point at the same server, so there's pretty low risk I missed anything.

> What's the story with www.getthunderbird.com. We own that as well, right?
> But we just redirect to thunderbird.net?

We do own it, yes. I don't remember why, but in the Mozilla Messaging days it was used as a marketing domain with a simple page you could directly download Thunderbird from. I think maybe because the TB download page used to be a bit buried in mozilla.org. That page was retired and it's been a redirect to the main TB download page ever since, so removing it from here simply eliminates one redirect.

Updated

Last year
Keywords: checkin-needed
Or maybe the just riffed of firefox, which still has www.getfirefox.com

Comment 11

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5c75efb0f01b
Update prefs to use thunderbird.net in place of mozillamessaging.com and mozilla.org. r=jorgk
Status: NEW → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 61.0
(In reply to Wayne Mery (:wsmwk) from comment #10)
> Or maybe the just riffed of firefox, which still has www.getfirefox.com

fun fact - according to http://forums.mozillazine.org/viewtopic.php?t=139225 www.getfirefox.com goes back at least 2004
(In reply to Wayne Mery (:wsmwk) from comment #10)
> Or maybe the just riffed of firefox, which still has www.getfirefox.com

https://bugzilla.mozilla.org/show_bug.cgi?id=249527 Sounds like you're right.
You need to log in before you can comment on or make changes to this bug.