Closed
Bug 1456772
Opened 6 years ago
Closed 6 years ago
Fix web console message_count reporting
Categories
(DevTools :: General, enhancement, P2)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: miker, Assigned: miker)
References
Details
Attachments
(1 file)
We were trying to send the message count from the content process so the ping was never sent... it must be sent from the chrome process.
Assignee | ||
Updated•6 years ago
|
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8970831 [details] Bug 1456772 - Fix web console message_count reporting https://reviewboard.mozilla.org/r/239608/#review245316 Looks good to me, just one question regarding tracking 0 messages ::: devtools/client/framework/toolbox.js:1915 (Diff revision 1) > + > + // Cold webconsole event message_count is handled in > + // devtools/client/webconsole/new-console-output-wrapper.js > + if (!cold) { > + this._telemetry.addEventProperty( > + "devtools.main", "enter", "webconsole", null, "message_count", 0); is this needed for the tracking?
Attachment #8970831 -
Flags: review?(ystartsev) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Yes... without it we don't send the message_count property so the ping is never sent.
Updated•6 years ago
|
No longer blocks: devtools-analytics
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30abe52251ba Fix web console message_count reporting r=yulia
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/30abe52251ba
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•