Fix web console message_count reporting

RESOLVED FIXED in Firefox 61

Status

enhancement
P2
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: miker, Assigned: miker)

Tracking

(Blocks 1 bug)

57 Branch
Firefox 61
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

We were trying to send the message count from the content process so the ping was never sent... it must be sent from the chrome process.
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Comment on attachment 8970831 [details]
Bug 1456772 - Fix web console message_count reporting

https://reviewboard.mozilla.org/r/239608/#review245316

Looks good to me, just one question regarding tracking 0 messages

::: devtools/client/framework/toolbox.js:1915
(Diff revision 1)
> +
> +      // Cold webconsole event message_count is handled in
> +      // devtools/client/webconsole/new-console-output-wrapper.js
> +      if (!cold) {
> +        this._telemetry.addEventProperty(
> +          "devtools.main", "enter", "webconsole", null, "message_count", 0);

is this needed for the tracking?
Attachment #8970831 - Flags: review?(ystartsev) → review+
Yes... without it we don't send the message_count property so the ping is never sent.
Moving to M1 for splitting off M2 work.
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30abe52251ba
Fix web console message_count reporting r=yulia
https://hg.mozilla.org/mozilla-central/rev/30abe52251ba
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.