1456788 - Flickering effect on iframe icon

Status: NEW

(DevTools :: General, defect, P3)

Description

[Daniel_A[:daschilean] [Please contact - [e-mail]]]

Attachment: tab_bardisable_javascript.gif

User Agent: Mozilla/5.0 (X11; Windows x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180424220100

Steps to reproduce:

1. Open Firefox Nightly 61.0a1 (2018-04-24) (64-bit)
2. Go to any webpages
3. Open Inspector (Press "F12")
4. From inspector settings enable "Enable browser chrome and add-on debugging toolboxes" and "Enable remote debugging"
5. Open Tools -> Web Developer -> Browser Toolbox
6. Select "Settings" from the "Meetball Menu" 
7. Click on "Disable JavaScript" checkbox from "Advanced settings"


Actual results:
Flickering effect is displayed on "iframe icon" from the upper right corner after checking the "Disable JavaScript" option.


Expected results:
The mentioned option should be checked without any flickering effect.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

This should be fixed by bug 1456069.

Comment 2

[Patrick Brosset <:pbro>]

I tested again on a local build (pulled from m-c today) and I can still see some flickering:
The button seems to become greyed out a little bit while the "disable javascript" setting is applied, and then turns normal again.
This might be fine. It's way less distracting than in attachment 8970851 [details].

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Right. Considering this only happens in the browser console and only when selecting "disable javascript" I think the minor flickering is acceptable. I would suggest this is either resolved by bug 1456069 or wontfix.

Comment 4

[Julian Descottes [:jdescottes]]

The flickering is also present on the regular toolbox, if you target a page that has iframes. 

The reason behind this is that "disable javascript" actually reloads the page, and while it reloads we don't know yet if we have iframes in the page and if we should enable the button. Maybe waiting before the complete load of the page before updating the button would help here.