Let the header bar use the toolbar colors when the Dark/Light themes are active

RESOLVED FIXED in Thunderbird 61.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 61.0

Thunderbird Tracking Flags

(thunderbird60 fixed, thunderbird61 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Assignee

Description

Last year
Actually the Dark/Light themes apply only on the main toolbar. We should add the header toolbar too.
Assignee

Comment 1

Last year
Make the header bar themeable and theme the textfields in the editContactPane.

This needs bug 1456813 applied first to work correctly.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8970861 - Flags: review?(jorgk)

Comment 2

Last year
Comment on attachment 8970861 [details] [diff] [review]
themeHeaderBar.patch

Works for me. Since you want uplift for the light/dark theme bug, this needs to be uplifted, too, together with bug 1456813. Otherwise it would be "half done".
Attachment #8970861 - Flags: review?(jorgk) → review+
Assignee

Comment 3

Last year
Yep, that was the plan. But I need to do a combined patch because beta has still the editContactOverlay.xul.
Keywords: checkin-needed

Comment 4

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/66989a037fc0
Allow the header bar to use the toolbar colors when the Dark/Light themes are active. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 61.0
Assignee

Comment 5

Last year
Posted patch themeHeaderBar-beta.patch (obsolete) — Splinter Review
This is the beta patch. I combined bug 1456813 into this patch because we don't rename the editContactOverlay.css. I had to do slight changes to make some selectors more specific because with the overlays the application order of the CSS files is a bit different.
Attachment #8971184 - Flags: approval-comm-beta?
Assignee

Comment 6

Last year
Sorry, I forgot to add this part in the first patch. The .headerValue had a fixed colour and didn't follow the theme colour.
Attachment #8971272 - Flags: review?(jorgk)
Assignee

Comment 7

Last year
Beta patch with the followup included.
Attachment #8971184 - Attachment is obsolete: true
Attachment #8971184 - Flags: approval-comm-beta?
Attachment #8971273 - Flags: approval-comm-beta?

Updated

Last year
Attachment #8971273 - Flags: approval-comm-beta? → approval-comm-beta+

Updated

Last year
Attachment #8971272 - Flags: review?(jorgk) → review+

Comment 8

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0193df9bf950
Follow-up: Remove a color definition which blocks the correct color on Mac. r=jorgk DONTBUILD
You need to log in before you can comment on or make changes to this bug.