Closed
Bug 1456820
Opened 6 years ago
Closed 6 years ago
Reorder fields in various gfx font structs for better packing
Categories
(Core :: Graphics: Text, enhancement)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(4 files)
5.74 KB,
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
1.58 KB,
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
10.99 KB,
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
5.27 KB,
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8970862 -
Flags: review?(lsalzman)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8970863 -
Flags: review?(lsalzman)
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8970864 -
Flags: review?(lsalzman)
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8970865 -
Flags: review?(lsalzman)
Assignee | ||
Comment 5•6 years ago
|
||
In my local (macosx64) build, these patches reduce sizeof(T) for each affected type as follows: nsFont: 96 -> 88 gfxFontStyle: 80 -> 72 gfxFontEntry: 272 -> 256 gfxFont: 232 -> 216
Updated•6 years ago
|
Attachment #8970862 -
Flags: review?(lsalzman) → review+
Updated•6 years ago
|
Attachment #8970863 -
Flags: review?(lsalzman) → review+
Updated•6 years ago
|
Attachment #8970864 -
Flags: review?(lsalzman) → review+
Updated•6 years ago
|
Attachment #8970865 -
Flags: review?(lsalzman) → review+
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d870719ab035 patch 1 - Reorder fields in nsFont for better packing. r=lsalzman https://hg.mozilla.org/integration/mozilla-inbound/rev/a021bec0b4d2 patch 2 - Reorder fields in gfxFontStyle for better packing. r=lsalzman https://hg.mozilla.org/integration/mozilla-inbound/rev/2758feefd02f patch 3 - Reorder fields in gfxFontEntry for better packing. r=lsalzman https://hg.mozilla.org/integration/mozilla-inbound/rev/83d7c4d3b227 patch 4 - Reorder fields in gfxFont for better packing. r=lsalzman
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d870719ab035 https://hg.mozilla.org/mozilla-central/rev/a021bec0b4d2 https://hg.mozilla.org/mozilla-central/rev/2758feefd02f https://hg.mozilla.org/mozilla-central/rev/83d7c4d3b227
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•