Closed Bug 1456820 Opened 2 years ago Closed 2 years ago

Reorder fields in various gfx font structs for better packing

Categories

(Core :: Graphics: Text, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

Attachments

(4 files)

No description provided.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
In my local (macosx64) build, these patches reduce sizeof(T) for each affected type as follows:
    nsFont:       96 -> 88
    gfxFontStyle: 80 -> 72
    gfxFontEntry: 272 -> 256
    gfxFont:      232 -> 216
Attachment #8970862 - Flags: review?(lsalzman) → review+
Attachment #8970863 - Flags: review?(lsalzman) → review+
Attachment #8970864 - Flags: review?(lsalzman) → review+
Attachment #8970865 - Flags: review?(lsalzman) → review+
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d870719ab035
patch 1 - Reorder fields in nsFont for better packing. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/a021bec0b4d2
patch 2 - Reorder fields in gfxFontStyle for better packing. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/2758feefd02f
patch 3 - Reorder fields in gfxFontEntry for better packing. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/83d7c4d3b227
patch 4 - Reorder fields in gfxFont for better packing. r=lsalzman
You need to log in before you can comment on or make changes to this bug.