Closed Bug 1456906 Opened 8 years ago Closed 8 years ago

[wpt-sync] Sync PR 10641 - Subtract scrollbar in PerpendicularContainingBlockLogicalHeight

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10641 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10641 Details from upstream follow. Manuel Rego Casasnovas <rego@igalia.com> wrote: > Subtract scrollbar in PerpendicularContainingBlockLogicalHeight > > This is an issue that happens in Flexbox and Grid Layout > and any other layout method that uses OverrideLogicalHeight. > In LayoutBox::PerpendicularContainingBlockLogicalHeight() > we were returning the OverrideContentLogicalHeight() plus > the scrollbar height. > That caused issue with orthogonal flows between flex/grid items > and their children. > > The issue is fixed just following the suggestion in the TODO > and using OverrideContentLogicalHeight() > (which doesn't include the scrollbar height). > > BUG=836827 > TEST=external/wpt/css/css-flexbox/percentage-size-subitems-001.html > TEST=external/wpt/css/css-grid/grid-items/percentage-size-subitems-001.html > > Change-Id: I0c7586449067aab78430defc831b2774136e2f0b > Reviewed-on: https://chromium-review.googlesource.com/1028012 > WPT-Export-Revision: 9f4db545d170d5d0e5c05d6ba71a93de86ee7605
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/0ef4a6df0c2a [wpt PR 10641] - Subtract scrollbar in PerpendicularContainingBlockLogicalHeight, a=testonly
https://hg.mozilla.org/mozilla-central/rev/0ef4a6df0c2a
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.