Closed Bug 1456936 Opened 2 years ago Closed 2 years ago

Fix test_analyser skip conditions

Categories

(Developer Documentation :: API: Web Audio, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dmajor, Assigned: dmajor)

Details

Attachments

(1 file)

[test_analyserNode.html]
skip-if = !asan || toolkit != android
[test_analyserScale.html]
skip-if = !asan || toolkit != android
[test_analyserNodeOutput.html]
skip-if = !asan || toolkit != android
[test_analyserNodePassThrough.html]
[test_analyserNodeWithGain.html]
skip-if = !asan || toolkit != android
[test_analyserNodeMinimum.html]
skip-if = !asan || toolkit != android

Currently these tests will only run on ASan-enabled Android builds (which don't exist). Based on bug 1408456 comment 4, I believe the intent was for this to be `!asan && toolkit != android`.
Attached patch patchSplinter Review
Assignee: nobody → dmajor
Attachment #8970978 - Flags: review?(padenot)
Comment on attachment 8970978 [details] [diff] [review]
patch

Review of attachment 8970978 [details] [diff] [review]:
-----------------------------------------------------------------

Ah good catch, thanks.
Attachment #8970978 - Flags: review?(padenot) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91c634efec59
Fix test_analyser skip conditions. r=padenot
https://hg.mozilla.org/mozilla-central/rev/91c634efec59
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.