1456985 - Having a project as a reviewer breaks lando

Status: RESOLVED FIXED

(Conduit :: Lando, defect, P1)

Description

[Steven MacLeod [:smacleod]]

Lando API is broken right now for revisions which specify a project as a reviewer. Most notably this happens for any vct change touching autoland.

Comment 1

[Phabricator Automation]

Attachment: reviewers: temporarily fix project reviewers (Bug 1456985).

Lando is breaking when a project is set as a reviewer, as it expects
to get information for each reviewer from 'user.search'. This quick
fix puts us back to defaulting to a username in this case, this time
using '<unknown>' instead of empty string ''.

Comment 2

[Steven MacLeod [:smacleod]]

Temporary fix is out and deployed. Proper fix to come.

Comment 3

[Mark Côté [:mcote]]

Probably not a regression, but something that should have worked before, hence P1.

Comment 4

[Phabricator Automation]

Attachment: reviewers: use name for project reviewers (Bug 1456985).

This change makes use of the `project.search` conduit method to find a
name for reviewers which are projects. `project.search` support has been
added to the PhabricatorDouble to allow for testing this. We will now
use the project name when referring to project reviewers and the
username when referring to user reviewers.

Because saying `username` for a reviewer who is not a user doesn't make
a whole lot of sense, some of reviewer fields on the revisions response
have been deprecated. `username` and `real_name` have been replaced with
`identifier` and `full_name` respectively. The old fields still return
the expected data, but they will be removed when Lando UI no longer uses
them.

The deprecated `is_blocking` reviewer field has been removed. All
deployed versions of Lando UI are up to date and no longer use this
field.

Comment 5

[Phabricator Automation]

Attachment: landoapi: switch away from deprecated fields (Bug 1456985).

Lando api has deprecated the reviewer information fields, replacing them
with new ones. This change brings usage up to date and updates the
canned data.

Depends on D1047.

Comment 6

[Phabricator Automation]

Comment on attachment 8971357 [details]
reviewers: use name for project reviewers (Bug 1456985).

Byron Jones ‹:glob› has approved the revision.

https://phabricator.services.mozilla.com/D1047

Comment 7

[Phabricator Automation]

Comment on attachment 8971359 [details]
landoapi: switch away from deprecated fields (Bug 1456985).

Byron Jones ‹:glob› has approved the revision.

https://phabricator.services.mozilla.com/D1048