Closed Bug 1456996 Opened 2 years ago Closed 2 years ago

[wdspec] get_named_cookie.py marks tests as fail inappropriately

Categories

(Testing :: geckodriver, defect, P1)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(3 files)

Similar to bug 1456799 there are failures like the following listed in the logs, which cause the tests to fail:

https://taskcluster-artifacts.net/dDWmPJHLRY601K6Ei09_VA/0/public/logs/live_backing.log

> [task 2018-04-25T21:06:56.808Z] 21:06:56     INFO - STDOUT:     def test_duplicated_cookie(session, url, server_config):
> [task 2018-04-25T21:06:56.809Z] 21:06:56     INFO - STDOUT:         session.url = url("/common/blank.html")
> [task 2018-04-25T21:06:56.809Z] 21:06:56     INFO - STDOUT:         clear_all_cookies(session)
> [task 2018-04-25T21:06:56.810Z] 21:06:56     INFO - STDOUT:         create_cookie_request = {
> [task 2018-04-25T21:06:56.810Z] 21:06:56     INFO - STDOUT:             "cookie": {
> [task 2018-04-25T21:06:56.810Z] 21:06:56     INFO - STDOUT:                 "name": "hello",
> [task 2018-04-25T21:06:56.811Z] 21:06:56     INFO - STDOUT:                 "value": "world",
> [task 2018-04-25T21:06:56.812Z] 21:06:56     INFO - STDOUT: >               "domain": server_config["domains"][""],
> [task 2018-04-25T21:06:56.813Z] 21:06:56     INFO - STDOUT:                 "path": "/",
> [task 2018-04-25T21:06:56.813Z] 21:06:56     INFO - STDOUT:                 "httpOnly": False,
> [task 2018-04-25T21:06:56.814Z] 21:06:56     INFO - STDOUT:                 "secure": False
> [task 2018-04-25T21:06:56.814Z] 21:06:56     INFO - STDOUT:             }
> [task 2018-04-25T21:06:56.814Z] 21:06:56     INFO - STDOUT:         }
> [task 2018-04-25T21:06:56.815Z] 21:06:56     INFO - STDOUT: E       TypeError: list indices must be integers, not str

This is clearly a coding bug, and the test should not have been marked as expected fail.
Attachment #8971112 - Flags: review?(mjzffr)
Attachment #8971113 - Flags: review?(mjzffr)
Attachment #8971114 - Flags: review?(mjzffr)
Comment on attachment 8971112 [details]
Bug 1456996 - [wdspec] Get named cookie tests have to use a shared custom get_named_cookie command.

https://reviewboard.mozilla.org/r/239910/#review245866
Attachment #8971112 - Flags: review?(mjzffr) → review+
Comment on attachment 8971113 [details]
Bug 1456996 - [wdclient] Add http-only support for setting a cookie.

https://reviewboard.mozilla.org/r/239912/#review245868
Attachment #8971113 - Flags: review?(mjzffr) → review+
Comment on attachment 8971114 [details]
Bug 1456996 - [wdspec] Fix test_duplicated_cookie for invalid domain usage.

https://reviewboard.mozilla.org/r/239914/#review245872
Attachment #8971114 - Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1b7f7e210c6
[wdspec] Get named cookie tests have to use a shared custom get_named_cookie command. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/1f4ce46796fc
[wdclient] Add http-only support for setting a cookie. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/9833513330b4
[wdspec] Fix test_duplicated_cookie for invalid domain usage. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/d1b7f7e210c6
https://hg.mozilla.org/mozilla-central/rev/1f4ce46796fc
https://hg.mozilla.org/mozilla-central/rev/9833513330b4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10675 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.