Closed Bug 1457005 Opened 2 years ago Closed 2 years ago
TRR can get stuck in CONFIRM
_FAILED state on a prefs typo
59 bytes, text/x-review-board-request
This is probably the reason why some people have reported they've needed to restart Firefox to make updated TRR prefs take effect: In all trr modes except 3, when the verification of the "confirmationNS" fails it ends up in CONFIRM_FAILED state and it doesn't retry. Not even when the prefs (like URI) is updated. So if you enter a typo in the URI or any other pref that makes TRR get initialized (and fail to verify that it works) and then fix the typo, TRR does not re-start its verification state machine. I propose we make all updates to a TRR pref check if the state is CONFIRM_FAILED and if so, we restart the state machine and check again, as with the updated settings it might work now.
Comment on attachment 8971059 [details] bug 1457005 - TRR: reset confirmation state machine on prefs update https://reviewboard.mozilla.org/r/239804/#review245846
Attachment #8971059 - Flags: review?(mcmanus) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/1936e3c9b600 TRR: reset confirmation state machine on prefs update r=mcmanus
You need to log in before you can comment on or make changes to this bug.