Closed Bug 1457010 Opened 2 years ago Closed 2 years ago

partner followup - gpg signing

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
Tracking Status
firefox61 --- fixed

People

(Reporter: nthomas, Assigned: nthomas)

References

Details

Attachments

(1 file)

We gpg sign "installers" on all platforms in the buildbot partner repack infra, and want to maintain that in taskcluster.
Comment on attachment 8971078 [details]
Bug 1457010 - gpg sign partner repacks,

https://reviewboard.mozilla.org/r/239850/#review245556

Good job! I'm not 100% sure about the transform, but our 61.0b9 build3 has gpg sigs, so lgtm!

::: taskcluster/taskgraph/transforms/repackage_signing_partner.py:70
(Diff revision 1)
>                  build_platform=attributes.get('build_platform'),
>                  build_type=attributes.get('build_type')
>              )
>          )
>  
> +        if 'linux' in dep_job.label:

`if 'linux' in dep_job.attributes['build_platform']:` is probably preferred, as long as that works.

::: taskcluster/taskgraph/transforms/repackage_signing_partner.py:73
(Diff revision 1)
>          )
>  
> +        if 'linux' in dep_job.label:
> +            # we want the repack job, via the dependencies for the the chunking-dummy dep_job
> +            for dep in dep_job.dependencies:
> +                if dep.startswith('release-partner-repack'):

Is `dep` a dict or a string here? I'm never really sure.
Attachment #8971078 - Flags: review?(aki) → review+
Comment on attachment 8971078 [details]
Bug 1457010 - gpg sign partner repacks,

https://reviewboard.mozilla.org/r/239850/#review245556

> `if 'linux' in dep_job.attributes['build_platform']:` is probably preferred, as long as that works.

Fixed.

> Is `dep` a dict or a string here? I'm never really sure.

In this case it's a dict of the form {a: a}, so I switched to explicitly using .values().
https://hg.mozilla.org/mozilla-central/rev/b59f651f46ec
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.