Closed
Bug 1457010
Opened 7 years ago
Closed 7 years ago
partner followup - gpg signing
Categories
(Release Engineering :: Release Automation, enhancement)
Release Engineering
Release Automation
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: nthomas, Assigned: nthomas)
References
Details
Attachments
(1 file)
We gpg sign "installers" on all platforms in the buildbot partner repack infra, and want to maintain that in taskcluster.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
There's a staging release at https://tools.taskcluster.net/groups/Y-bKtkRhTNq1RxNxl85wgQ.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8971078 [details]
Bug 1457010 - gpg sign partner repacks,
https://reviewboard.mozilla.org/r/239850/#review245556
Good job! I'm not 100% sure about the transform, but our 61.0b9 build3 has gpg sigs, so lgtm!
::: taskcluster/taskgraph/transforms/repackage_signing_partner.py:70
(Diff revision 1)
> build_platform=attributes.get('build_platform'),
> build_type=attributes.get('build_type')
> )
> )
>
> + if 'linux' in dep_job.label:
`if 'linux' in dep_job.attributes['build_platform']:` is probably preferred, as long as that works.
::: taskcluster/taskgraph/transforms/repackage_signing_partner.py:73
(Diff revision 1)
> )
>
> + if 'linux' in dep_job.label:
> + # we want the repack job, via the dependencies for the the chunking-dummy dep_job
> + for dep in dep_job.dependencies:
> + if dep.startswith('release-partner-repack'):
Is `dep` a dict or a string here? I'm never really sure.
Attachment #8971078 -
Flags: review?(aki) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8971078 [details]
Bug 1457010 - gpg sign partner repacks,
https://reviewboard.mozilla.org/r/239850/#review245556
> `if 'linux' in dep_job.attributes['build_platform']:` is probably preferred, as long as that works.
Fixed.
> Is `dep` a dict or a string here? I'm never really sure.
In this case it's a dict of the form {a: a}, so I switched to explicitly using .values().
Pushed by nthomas@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b59f651f46ec
gpg sign partner repacks, r=aki
Assignee | ||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•