Closed
Bug 1457033
Opened 7 years ago
Closed 6 years ago
Convert TransformFunction to servo's AnimationValue directly
Categories
(Core :: Graphics, enhancement, P3)
Core
Graphics
Tracking
()
RESOLVED
DUPLICATE
of bug 1529002
People
(Reporter: hiro, Assigned: boris)
Details
(Whiteboard: [gfx-noted])
Now we convert TransformFunction [1] to nsCSSValueSharedList and then convert the nsCSSValueSharedList to servo's animation value. It's bit inefficient, we can convert it directly to the servo's animation value.
A cumbersome point to expose the TransformFunction type in bindings is that the auto-generated header is $obj-dir/ipc/ipdl/_ipdlheaders/mozilla/layers/LayersMessages.h, not in dist/include and the header includes a bunch of annoying headers.
[1] https://hg.mozilla.org/mozilla-central/file/99c19a66c3a2/gfx/layers/ipc/LayersMessages.ipdlh#l152
|
||
Updated•7 years ago
|
Priority: -- → P3
Whiteboard: [gfx-noted]
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → boris.chiou
|
|
Assignee | |
Comment 1•6 years ago
|
||
I may do this together with Bug 1425837.
|
|
Assignee | |
Comment 2•6 years ago
•
|
||
(In reply to Boris Chiou [:boris] from comment #1)
I may do this together with Bug 1425837.
i.e. Could be a follow-up of Bug 1425837.
|
|
Assignee | |
Comment 3•6 years ago
|
||
In Bug 1529002, we use cbindgen to generate transform types which could be used in both C++ and Rust (i.e. same memory layout), so we don't have to convert them into nsCSSValueSharedList. Right now, we use the generated types directly from/to their ServoAnimationValue.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•