Closed Bug 1457039 Opened 7 years ago Closed 7 years ago

Remote debugger to Android doesn't work after 2018-04-25 build.

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: m_kato, Assigned: miker)

References

Details

When connecting Firefox Android (2018-04-25 build) for devtools via WebIDE, I cannot connect /work well after 2018-04-25 build. On Firefox android, the following error is outputted. 04-26 10:38:07.806 2907 2946 E GeckoConsole: [JavaScript Error: "Error occurred while creating actor 'undefined: ReferenceError: Telemetry is not defined 04-26 10:38:07.806 2907 2946 E GeckoConsole: Stack: WebConsoleActor@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/webconsole.js:79:3 04-26 10:38:07.806 2907 2946 E GeckoConsole: ObservedActorFactory.prototype.createActor@resource://devtools/server/actors/common.js:115:18 04-26 10:38:07.806 2907 2946 E GeckoConsole: _getOrCreateActor@resource://devtools/server/main.js:1587:17 04-26 10:38:07.806 2907 2946 E GeckoConsole: onPacket@resource://devtools/server/main.js:1744:17 04-26 10:38:07.806 2907 2946 E GeckoConsole: receiveMessage@resource://devtools/shared/transport/transport.js:735:7 04-26 10:38:07.806 2907 2946 E GeckoConsole: Line: 79, column: 3" {file: "resource://devtools/server/main.js" line: 1613}] 04-26 10:38:07.806 2907 2946 E GeckoConsole: _unknownError@resource://devtools/server/main.js:1613:5 04-26 10:38:07.806 2907 2946 E GeckoConsole: _getOrCreateActor@resource://devtools/server/main.js:1590:29 04-26 10:38:07.806 2907 2946 E GeckoConsole: onPacket@resource://devtools/server/main.js:1744:17 04-26 10:38:07.806 2907 2946 E GeckoConsole: receiveMessage@resource://devtools/shared/transport/transport.js:735:7
Summary: Remote debugger to Android doesn't work after 2018-04-05 build. → Remote debugger to Android doesn't work after 2018-04-25 build.
It seems to be regression by bug 1441070. Maybe, the following line has bug. https://searchfox.org/mozilla-central/rev/78dbe34925f04975f16cb9a5d4938be714d41897/devtools/server/actors/webconsole.js#33 Should we move telemetry.js to shared?
Blocks: 1441070
Flags: needinfo?(mratcliffe)
I am not sure it makes sense to collect telemetry on server like this...? Perhaps the probe should be moved to the console client.
This is fixed by bug 1456772
Flags: needinfo?(mratcliffe)
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Has Regression Range: --- → irrelevant
Has STR: --- → yes
OS: Unspecified → All
Hardware: Unspecified → All
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.