Leak in WorkerEventTarget::Dispatch()

RESOLVED FIXED in Firefox 61

Status

()

defect
P2
normal
RESOLVED FIXED
Last year
3 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

58 Branch
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
WorkerEventTarget::Dispatch receives an already_AddRefed<nsIRunnable> parameter, but if mWorkerPrivate is null, it doesn't finish the moving of the runnable:

https://searchfox.org/mozilla-central/rev/78dbe34925f04975f16cb9a5d4938be714d41897/dom/workers/WorkerEventTarget.cpp#101-110
Assignee

Comment 1

Last year
Attachment #8971150 - Flags: review?(bugs)
Attachment #8971150 - Flags: review?(bugs) → review+
Priority: -- → P2

Comment 2

Last year
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d50f31ee0a5b
Fix a leak in WorkerEventTarget::Dispatch() about how already_AddRefed<> params are handled, r=smaug

Comment 3

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/d50f31ee0a5b
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Blocks: 1456466
No longer depends on: 1456466
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.