Make the menulist dropmarker themeable on Windows

RESOLVED FIXED in Thunderbird 61.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 61.0
All
Windows

Thunderbird Tracking Flags

(thunderbird60 fixed, thunderbird61 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
The menulist dropmarker doesn't change its colour to white when we use the dark theme.
Assignee

Comment 1

Last year
To test this add the "Folder Location" or "Mail Views" menulist to the main toolbar and select the dark theme.

We used already a dropmarker icon on the composer with hard coded colours. This patch removes it and uses the dropmarker we already use for the buttons. This one uses the currentColor.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8971158 - Flags: review?(jorgk)

Comment 2

Last year
Is this a beta uplift candidate?
Assignee

Comment 3

Last year
To make the dark theme better, yes. The patch applies to beta without problems.

Comment 4

Last year
Comment on attachment 8971158 [details] [diff] [review]
win-dropmarker.patch

Very nice, definitely necessary for beta.
Attachment #8971158 - Flags: review?(jorgk)
Attachment #8971158 - Flags: review+
Attachment #8971158 - Flags: approval-comm-beta+
Assignee

Updated

Last year
Keywords: checkin-needed

Comment 5

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f25a2f3b2dd0
Make the menulist dropmarker themeable on Windows. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.