Assertion failure: !StylistNeedsUpdate() @ mozilla::ServoStyleSet::PreTraverseSync

RESOLVED FIXED in Firefox 61

Status

()

defect
RESOLVED FIXED
Last year
Last year

People

(Reporter: bc, Assigned: emilio)

Tracking

(Blocks 1 bug, {assertion, regressionwindow-wanted})

61 Branch
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox-esr60 wontfix, firefox59 unaffected, firefox60 wontfix, firefox61 fixed)

Details

()

Attachments

(4 attachments)

Reporter

Description

Last year
Posted file Linux Debug log
1. http://www.dardarkom.com/37640-watch-and-download-17-again-2009-online.html

Windows/Linux Nightly/61 at least.

Pretty reliable though not 100%. May need to reload or try a couple of times.

2. Assertion failure: !StylistNeedsUpdate(), at /builds/worker/workspace/build/src/layout/style/ServoStyleSet.cpp:458
#01: mozilla::ServoStyleSet::ResolveStyleLazily [layout/style/ServoStyleSet.cpp:615]
#02: nsComputedDOMStyle::DoGetComputedStyleNoFlush [mfbt/AlreadyAddRefed.h:168]
#03: nsComputedDOMStyle::UpdateCurrentStyleSources [mfbt/AlreadyAddRefed.h:168]
#04: nsComputedDOMStyle::GetPropertyCSSValueWithoutWarning [layout/style/nsComputedDOMStyle.cpp:1040]
#05: nsComputedDOMStyle::GetPropertyValue [mfbt/AlreadyAddRefed.h:168]
#06: nsComputedDOMStyle::GetPropertyValue [xpcom/string/nsTSubstring.h:77]
#07: nsDOMCSSDeclaration::GetWebkitBoxSizing [dom/bindings/ErrorResult.h:377]
#08: mozilla::dom::CSS2PropertiesBinding::get_boxSizing [s3:gecko-generated-sources:8b55b957851f788c3e0fd080986975baef96ee47cf90c19763357ffb8779240003e7dfbf55130317161ca738706204d4d7916065c92d018c19f322d637be17a1/dom/bindings/CSS2PropertiesBinding.cpp::6317]
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Flags: needinfo?(emilio)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

Last year
mozreview-review
Comment on attachment 8971210 [details]
Bug 1457102: Avoid all the work if the compat mode hasn't actually changed.

https://reviewboard.mozilla.org/r/239998/#review246004
Attachment #8971210 - Flags: review?(cam) → review+

Comment 5

Last year
mozreview-review
Comment on attachment 8971211 [details]
Bug 1457102: Avoid grabbing a reference to the pres context.

https://reviewboard.mozilla.org/r/240000/#review246008
Attachment #8971211 - Flags: review?(cam) → review+

Comment 6

Last year
mozreview-review
Comment on attachment 8971212 [details]
Bug 1457102: Ensure a style flush happens after a compat mode change.

https://reviewboard.mozilla.org/r/240002/#review246010
Attachment #8971212 - Flags: review?(cam) → review+

Comment 7

Last year
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/681cf57b9ff3
Avoid all the work if the compat mode hasn't actually changed. r=heycam
https://hg.mozilla.org/integration/autoland/rev/860f468355b9
Avoid grabbing a reference to the pres context. r=heycam
https://hg.mozilla.org/integration/autoland/rev/9806b8af0e6f
Ensure a style flush happens after a compat mode change. r=heycam
AFAICT, this also affects 60 (based on blame). Is there a user impact which warrants backport consideration or can this ride the trains?
Flags: needinfo?(emilio)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)
> AFAICT, this also affects 60 (based on blame). Is there a user impact which
> warrants backport consideration or can this ride the trains?

I don't think so. This theoretically could have user-visible impact / lack of correctness. But I haven't seen that at all (in this case the compat mode had not even changed). I don't think it's worth backporting.
Flags: needinfo?(emilio)
You need to log in before you can comment on or make changes to this bug.