Closed
Bug 1457103
Opened 3 years ago
Closed 3 years ago
Implement missing variation-font query APIs in the Android (FT2Fonts) backend
Categories
(Core :: Graphics: Text, enhancement)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
5.29 KB,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
6.13 KB,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
6.52 KB,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
The FT2Fonts backend doesn't provide overrides for the (empty) default implementations of gfxFontEntry::HasVariations(), GetVariationAxes(), and GetVariationInstances(). This will (I believe) prevent the font inspector working fully for variation fonts when targetting Firefox on Android, even though the fonts work OK for rendering.
Assignee | ||
Comment 1•3 years ago
|
||
Attachment #8971288 -
Flags: review?(jwatt)
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•3 years ago
|
||
Attachment #8971289 -
Flags: review?(jwatt)
Assignee | ||
Comment 3•3 years ago
|
||
Attachment #8971290 -
Flags: review?(jwatt)
Updated•3 years ago
|
Attachment #8971288 -
Flags: review?(jwatt) → review+
Updated•3 years ago
|
Attachment #8971289 -
Flags: review?(jwatt) → review+
Comment 4•3 years ago
|
||
Comment on attachment 8971290 [details] [diff] [review] patch 3 - Make gfxFontEntry::GetVariationAxes and GetVariationInstances pure virtual, and provide missing subclass implementations Review of attachment 8971290 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/thebes/gfxFontEntry.h @@ +365,5 @@ > > bool SupportsScriptInGSUB(const hb_tag_t* aScriptTags); > > + // For variation font support; font backends that don't support variations > + // should provide empty implementations. Doxygen style while you're here, please. @@ +370,2 @@ > virtual bool HasVariations() = 0; > + Remove white space on empty line. @@ +370,5 @@ > virtual bool HasVariations() = 0; > + > + virtual void > + GetVariationAxes(nsTArray<gfxFontVariationAxis>& aVariationAxes) = 0; > + Remove white space on empty line.
Attachment #8971290 -
Flags: review?(jwatt) → review+
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/46864f33859e patch 1 - Make gfxFontEntry::HasVariations a pure-virtual method, and fill in missing subclass implementations, particularly in FT2FontEntry. r=jwatt https://hg.mozilla.org/integration/mozilla-inbound/rev/c4e1dc66dae2 patch 2 - Refactor logic from gfxFontconfigFontEntry implementations of GetVariationAxes and GetVariationInstances to gfxFT2Utils, where it can be shared by the gfxFT2Fonts backend. r=jwatt https://hg.mozilla.org/integration/mozilla-inbound/rev/f1c7ad9294b3 patch 3 - Make gfxFontEntry::GetVariationAxes and GetVariationInstances pure virtual, and provide missing subclass implementations. r=jwatt
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/46864f33859e https://hg.mozilla.org/mozilla-central/rev/c4e1dc66dae2 https://hg.mozilla.org/mozilla-central/rev/f1c7ad9294b3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•