1457115 - Simplify browser_ext_tabs_executeScript_bad test

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[Rob Wu [:robwu]]

browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js currently calls executeScript twice, where the second executeScript call is used to signal completion of the first test. This was done because at the introduction of the test tabs.executeScript did not support callbacks.

In bug 1399348 I added "await" to the first call, to make the test more deterministic. I did not make other changes to see if the intermittent would be fixed by that change only.

Eventually, after getting the desired answer, the test can be simplified further by removing the second executeScript call.

This also applies to the Android test, which is a copy of the above test:
mobile/android/components/extensions/test/mochitest/test_ext_tabs_executeScript_bad.html

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1457115 - Simplify *_ext_tabs_executeScript_bad.*

Review commit: https://reviewboard.mozilla.org/r/246540/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246540/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8980364 [details]
Bug 1457115 - Simplify *_ext_tabs_executeScript_bad.*

https://reviewboard.mozilla.org/r/246540/#review266822

Looks good to me, thanks!

r=me on green try

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83e6d44180c0
Simplify *_ext_tabs_executeScript_bad.* r=rpl

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/83e6d44180c0