Closed Bug 1457148 Opened 2 years ago Closed 2 years ago

Crash in mozilla::a11y::Accessible::Bounds

Categories

(DevTools :: Accessibility Tools, defect, P1)

Unspecified
Windows 10
defect

Tracking

(firefox-esr52 unaffected, firefox59 unaffected, firefox60 unaffected, firefox61blocking verified)

VERIFIED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 blocking verified

People

(Reporter: calixte, Assigned: yzen)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(2 files, 2 obsolete files)

This bug was filed from the Socorro interface and is
report bp-42d06bc2-f6d1-4c53-9bcb-81abf0180426.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::a11y::Accessible::Bounds accessible/generic/Accessible-inl.h:150
1 xul.dll mozilla::a11y::AccessibleWrap::accLocation accessible/windows/msaa/AccessibleWrap.cpp:922
2 xul.dll mozilla::a11y::HandlerProvider::BuildDynamicIA2Data accessible/ipc/win/HandlerProvider.cpp:286
3 xul.dll mozilla::a11y::HandlerProvider::BuildInitialIA2Data accessible/ipc/win/HandlerProvider.cpp:415
4 xul.dll mozilla::detail::RunnableMethodImpl<mozilla::a11y::HandlerProvider*, void  xpcom/threads/nsThreadUtils.h:1216
5 xul.dll mozilla::mscom::MainThreadInvoker::MainThreadAPC ipc/mscom/MainThreadInvoker.cpp:187
6 ntdll.dll RtlDispatchAPC 
7 ntdll.dll KiUserApcDispatch 
8 ntdll.dll NtTestAlert 
9 xul.dll mozilla::SchedulerGroup::Runnable::Run xpcom/threads/SchedulerGroup.cpp:337

=============================================================

There are 12 crashes (from 3 installations) in nightly 61 with buildid 20180426100055. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1450927.

[1] https://hg.mozilla.org/mozilla-central/rev?node=b58c8b754ce2
Flags: needinfo?(yzenevich)
Yes, Looking at it right now.
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Flags: needinfo?(yzenevich)
Attached patch 1457148 patch (obsolete) — Splinter Review
Attachment #8971299 - Flags: review?(surkov.alexander)
Attached patch 1457148 patch v2Splinter Review
Attachment #8971299 - Attachment is obsolete: true
Attachment #8971299 - Flags: review?(surkov.alexander)
Attachment #8971302 - Flags: review?(surkov.alexander)
Comment on attachment 8971302 [details] [diff] [review]
1457148 patch v2

Review of attachment 8971302 [details] [diff] [review]:
-----------------------------------------------------------------

yep, I like this one better!
Attachment #8971302 - Flags: review?(surkov.alexander) → review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2321cd280739
fix crash in Accessible::Bounds. r=surkov
https://hg.mozilla.org/mozilla-central/rev/2321cd280739
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
There still are 147 crashes in nightly with buildid >= 20180427100500.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 61 → ---
Duplicate of this bug: 1457756
This is still making ff61 unusable for any one running a screen reader.
Attached patch 1457148 part 2 (obsolete) — Splinter Review
Attachment #8972105 - Flags: review?(surkov.alexander)
Comment on attachment 8972105 [details] [diff] [review]
1457148 part 2

Review of attachment 8972105 [details] [diff] [review]:
-----------------------------------------------------------------

r=me but please move out Bounds definition from inl file
Attachment #8972105 - Flags: review?(surkov.alexander) → review+
Carry over r+
Attachment #8972105 - Attachment is obsolete: true
Attachment #8972107 - Flags: review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ee25bda924e
ensure bounds does not crash for application accessible. r=surkov
https://hg.mozilla.org/mozilla-central/rev/3ee25bda924e
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
#3 overall top content process crash -> blocking. So far, things are looking good with today's Nightly results, though.
Severity: critical → blocker
Priority: -- → P1
This is fixt in latest build. Thanks for all your hard work and a quick fix.
Verified fixed on Windows 10 x64 using the latest Nightly 61.0a1(Build ID: 20180501220047).
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.