Closed Bug 1457208 Opened 3 years ago Closed 3 years ago

Change ContentParent::RecvPlaySound to use IPC_FAIL_NO_REASON instead of KillHard

Categories

(Core :: DOM: Content Processes, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Directly calling KillHard() doesn't play super nicely with the fuzzer. IPC_FAIL_NO_REASON has the same effect, but is nicer for the IPC fuzzer :-)
Attachment #8971308 - Flags: review?(mdeboer)
Comment on attachment 8971308 [details]
Bug 1457208 - use IPC_FAIL_NO_REASON instead of KillHard in ContentParent::RecvPlaySound;

https://reviewboard.mozilla.org/r/240068/#review246358

LGTM!
Attachment #8971308 - Flags: review?(mdeboer) → review+
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22c284b4f13e
use IPC_FAIL_NO_REASON instead of KillHard in ContentParent::RecvPlaySound; r=mikedeboer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/22c284b4f13e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.