1457311 - Record JS memory allocation through DOM paths

Status: NEW

(DevTools :: Memory, enhancement, P3)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

We can't presently record allocations of DOM objects (I think bug 1057057 is on file for that), but perhaps there is a shortcut we could take. Chrome's devtools trace object allocations through DOM nodes like event listeners, which is a very common cause of memory leaks:

https://v8project.blogspot.ca/2018/03/tracing-js-dom.html

We should do this too, if it is less work than bug 1057057 and any other dependencies.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Hi Panos!

(In reply to Panos Astithas [:past] (please ni?) from comment #0)
> We can't presently record allocations of DOM objects

We can't record the allocation of the C++ object, but we totally should be recording the JS reflector object already.

> (I think bug 1057057 is on file for that),

This is about tracing edges in the cycle collector's heap graph so we can see more already-allocated things in heap snapshots, not really about recording allocations.

> Chrome's
> devtools trace object allocations through DOM nodes like event listeners,
> which is a very common cause of memory leaks:
> 
> https://v8project.blogspot.ca/2018/03/tracing-js-dom.html

It looks like they implemented the equivalent of bug 1057057.

It isn't clear to me what this bug is asking for that is different from 1057057 -- can we close this bug or clarify further?