Closed
Bug 1457317
Opened 7 years ago
Closed 7 years ago
Show a title for the add/edit pages
Categories
(Firefox :: WebPayments UI, enhancement, P1)
Firefox
WebPayments UI
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
Details
(Whiteboard: [webpayments])
Attachments
(1 file)
The add/edit address and basic card screens should have a title that says "Add Shipping Address" for example.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee | ||
Updated•7 years ago
|
Whiteboard: [webpayments]
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8971431 [details]
Bug 1457317 - Show a title for the add/edit pages.
https://reviewboard.mozilla.org/r/240182/#review245998
::: toolkit/components/payments/res/paymentRequest.xhtml:95
(Diff revision 1)
> <address-picker class="shipping-related"
> data-add-link-label="&address.addLink.label;"
> data-edit-link-label="&address.editLink.label;"
> + data-add-shipping-address-title="&shippingAddress.addPage.title;"
> + data-edit-shipping-address-title="&shippingAddress.editPage.title;"
> + data-add-delivery-address-title="&deliveryAddress.addPage.title;"
> + data-edit-delivery-address-title="&deliveryAddress.editPage.title;"
> + data-add-pickup-address-title="&pickupAddress.addPage.title;"
> + data-edit-pickup-address-title="&pickupAddress.editPage.title;"
I don't think address-picker should know about shipping vs. delivery vs. pickup. The payment-summary component can set one add and one edit attribute for the appropriate string.
::: toolkit/components/payments/res/paymentRequest.xhtml:121
(Diff revision 1)
> + data-add-payer-title="&payer.addPage.title;"
> + data-edit-payer-title="&payer.editPage.title;"
As above, the payer attribute should use the same generic add/edit title attribute.
Attachment #8971431 -
Flags: review?(MattN+bmo)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8971431 [details]
Bug 1457317 - Show a title for the add/edit pages.
https://reviewboard.mozilla.org/r/240182/#review246016
Attachment #8971431 -
Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/fec4af27b939
Show a title for the add/edit pages. r=MattN
Comment 6•7 years ago
|
||
Backed out changeset for conflicts during backout.
https://hg.mozilla.org/integration/autoland/rev/4a9e29cddadee9ccc1e7ce00f9a9f29302a802f1
Flags: needinfo?(jaws)
Updated•7 years ago
|
Product: Toolkit → Firefox
Version: unspecified → Trunk
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a6c8a95fc9f
Show a title for the add/edit pages. r=MattN
Comment 9•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•