1457317 - Show a title for the add/edit pages

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The add/edit address and basic card screens should have a title that says "Add Shipping Address" for example.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1457317 - Show a title for the add/edit pages.

Review commit: https://reviewboard.mozilla.org/r/240182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240182/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8971431 [details]
Bug 1457317 - Show a title for the add/edit pages.

https://reviewboard.mozilla.org/r/240182/#review245998

::: toolkit/components/payments/res/paymentRequest.xhtml:95
(Diff revision 1)
>            <address-picker class="shipping-related"
>                            data-add-link-label="&address.addLink.label;"
>                            data-edit-link-label="&address.editLink.label;"
> +                          data-add-shipping-address-title="&shippingAddress.addPage.title;"
> +                          data-edit-shipping-address-title="&shippingAddress.editPage.title;"
> +                          data-add-delivery-address-title="&deliveryAddress.addPage.title;"
> +                          data-edit-delivery-address-title="&deliveryAddress.editPage.title;"
> +                          data-add-pickup-address-title="&pickupAddress.addPage.title;"
> +                          data-edit-pickup-address-title="&pickupAddress.editPage.title;"

I don't think address-picker should know about shipping vs. delivery vs. pickup. The payment-summary component can set one add and one edit attribute for the appropriate string.

::: toolkit/components/payments/res/paymentRequest.xhtml:121
(Diff revision 1)
> +                          data-add-payer-title="&payer.addPage.title;"
> +                          data-edit-payer-title="&payer.editPage.title;"

As above, the payer attribute should use the same generic add/edit title attribute.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8971431 [details]
Bug 1457317 - Show a title for the add/edit pages.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240182/diff/1-2/

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8971431 [details]
Bug 1457317 - Show a title for the add/edit pages.

https://reviewboard.mozilla.org/r/240182/#review246016

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fec4af27b939
Show a title for the add/edit pages. r=MattN

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out changeset for conflicts during backout. 

https://hg.mozilla.org/integration/autoland/rev/4a9e29cddadee9ccc1e7ce00f9a9f29302a802f1

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8971431 [details]
Bug 1457317 - Show a title for the add/edit pages.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240182/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a6c8a95fc9f
Show a title for the add/edit pages. r=MattN

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7a6c8a95fc9f