Closed Bug 1457317 Opened 3 years ago Closed 3 years ago

Show a title for the add/edit pages

Categories

(Firefox :: WebPayments UI, enhancement, P1)

Product:
Firefox
Component:
WebPayments UI
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

(Whiteboard: [webpayments])

Attachments

(1 file)

Bug 1457317 - Show a title for the add/edit pages.
59 bytes, text/x-review-board-request
MattN
: review+
Details 
The add/edit address and basic card screens should have a title that says "Add Shipping Address" for example.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [webpayments]
Comment on attachment 8971431 [details]
Bug 1457317 - Show a title for the add/edit pages.

https://reviewboard.mozilla.org/r/240182/#review245998

::: toolkit/components/payments/res/paymentRequest.xhtml:95
(Diff revision 1)
>            <address-picker class="shipping-related"
>                            data-add-link-label="&address.addLink.label;"
>                            data-edit-link-label="&address.editLink.label;"
> +                          data-add-shipping-address-title="&shippingAddress.addPage.title;"
> +                          data-edit-shipping-address-title="&shippingAddress.editPage.title;"
> +                          data-add-delivery-address-title="&deliveryAddress.addPage.title;"
> +                          data-edit-delivery-address-title="&deliveryAddress.editPage.title;"
> +                          data-add-pickup-address-title="&pickupAddress.addPage.title;"
> +                          data-edit-pickup-address-title="&pickupAddress.editPage.title;"

I don't think address-picker should know about shipping vs. delivery vs. pickup. The payment-summary component can set one add and one edit attribute for the appropriate string.

::: toolkit/components/payments/res/paymentRequest.xhtml:121
(Diff revision 1)
> +                          data-add-payer-title="&payer.addPage.title;"
> +                          data-edit-payer-title="&payer.editPage.title;"

As above, the payer attribute should use the same generic add/edit title attribute.
Attachment #8971431 - Flags: review?(MattN+bmo)
Comment on attachment 8971431 [details]
Bug 1457317 - Show a title for the add/edit pages.

https://reviewboard.mozilla.org/r/240182/#review246016
Attachment #8971431 - Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/fec4af27b939
Show a title for the add/edit pages. r=MattN
Backed out changeset for conflicts during backout. 

https://hg.mozilla.org/integration/autoland/rev/4a9e29cddadee9ccc1e7ce00f9a9f29302a802f1
Flags: needinfo?(jaws)
Product: Toolkit → Firefox
Version: unspecified → Trunk
Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a6c8a95fc9f
Show a title for the add/edit pages. r=MattN
https://hg.mozilla.org/mozilla-central/rev/7a6c8a95fc9f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.