Port bug 1445671 to TB: Stop using -moz-font-smoothing-background-color for the selected tab when using a lightweight theme

RESOLVED FIXED in Thunderbird 61.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 61.0
All
macOS

Thunderbird Tracking Flags

(thunderbird60 fixed, thunderbird61 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
In bug 14456671 is written that it's only visible on some LW-themes. We should follow to be on the safe side.
Assignee

Comment 1

Last year
Direct port of https://hg.mozilla.org/mozilla-central/rev/7b8e832071f1
The only difference is that we use [selected="true"] instead of [visuallyselected=true].
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8971422 - Flags: review?(jorgk)

Comment 2

Last year
Comment on attachment 8971422 [details] [diff] [review]
font-smoothing.patch

(In reply to Richard Marti (:Paenglab) from comment #1)
> The only difference is that we use [selected="true"] instead of
> [visuallyselected=true].
Can you explain that difference?
Attachment #8971422 - Flags: review?(jorgk) → review+
Assignee

Comment 3

Last year
I'm not 100% sure, but I think visuallyselected is only set when the tab is selected and visible on the tab bar and not in the overflow. Selected is also set when it's in the overflow and not visible but selected.
Keywords: checkin-needed

Comment 4

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2ca60f1a2b5c
Port bug 1445671 to TB: Stop using -moz-font-smoothing-background-color for the selected tab when using a lightweight theme. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 61.0
Assignee

Comment 5

Last year
Comment on attachment 8971422 [details] [diff] [review]
font-smoothing.patch

It's for an Edge case but then we are on the safe side. And later uplifts to this file apply better.

Should be checked-in after bug 1457712 to not rot its beta patch.
Attachment #8971422 - Flags: approval-comm-beta?

Updated

Last year
Attachment #8971422 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.