1457320 - Port bug 1445671 to TB: Stop using -moz-font-smoothing-background-color for the selected tab when using a lightweight theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

In bug 14456671 is written that it's only visible on some LW-themes. We should follow to be on the safe side.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: font-smoothing.patch

Direct port of https://hg.mozilla.org/mozilla-central/rev/7b8e832071f1
The only difference is that we use [selected="true"] instead of [visuallyselected=true].

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8971422 [details] [diff] [review]
font-smoothing.patch

(In reply to Richard Marti (:Paenglab) from comment #1)
> The only difference is that we use [selected="true"] instead of
> [visuallyselected=true].
Can you explain that difference?

Comment 3

[Richard Marti (:Paenglab)]

I'm not 100% sure, but I think visuallyselected is only set when the tab is selected and visible on the tab bar and not in the overflow. Selected is also set when it's in the overflow and not visible but selected.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2ca60f1a2b5c
Port bug 1445671 to TB: Stop using -moz-font-smoothing-background-color for the selected tab when using a lightweight theme. r=jorgk

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 8971422 [details] [diff] [review]
font-smoothing.patch

It's for an Edge case but then we are on the safe side. And later uplifts to this file apply better.

Should be checked-in after bug 1457712 to not rot its beta patch.

Comment 6

[Jorg K (CEST = GMT+2)]

Beta (TB 60 beta 6):
https://hg.mozilla.org/releases/comm-beta/rev/aa4d68e63413f951bd0b3f70752edee2c3aed612