Closed
Bug 1457326
Opened 3 years ago
Closed 3 years ago
Add coverage status to getBuildConfiguration
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
People
(Reporter: gkw, Assigned: gkw)
Details
Attachments
(1 file, 1 obsolete file)
908 bytes,
patch
|
gkw
:
review+
|
Details | Diff | Splinter Review |
It will be nice to know if a js shell was compiled with --enable-coverage. I based this patch off bug 998596. Jan, do you mind checking if this patch works as expected?
Attachment #8971428 -
Flags: review?(jdemooij)
![]() |
Assignee | |
Updated•3 years ago
|
Assignee: nobody → nth10sd
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 1•3 years ago
|
||
Also, I'm not sure whether the ordering of items in getBuildConfiguration matters or not...
Comment 2•3 years ago
|
||
Comment on attachment 8971428 [details] [diff] [review] patch Review of attachment 8971428 [details] [diff] [review]: ----------------------------------------------------------------- Seems straightforward enough. Looks good to me.
Attachment #8971428 -
Flags: review?(jdemooij) → review+
![]() |
Assignee | |
Comment 3•3 years ago
|
||
Bringing over r+. This version sets the right commit message.
Attachment #8971428 -
Attachment is obsolete: true
Attachment #8971445 -
Flags: review+
![]() |
Assignee | |
Updated•3 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d9515d63a7cf Add coverage status to getBuildConfiguration, r=sfink
Keywords: checkin-needed
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d9515d63a7cf
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•