Closed Bug 1457326 Opened 4 years ago Closed 4 years ago

Add coverage status to getBuildConfiguration

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: gkw, Assigned: gkw)

Details

Attachments

(1 file, 1 obsolete file)

patch v2
908 bytes, patch
gkw
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
It will be nice to know if a js shell was compiled with --enable-coverage. I based this patch off bug 998596.

Jan, do you mind checking if this patch works as expected?
Attachment #8971428 - Flags: review?(jdemooij)
Assignee: nobody → nth10sd
Status: NEW → ASSIGNED
Also, I'm not sure whether the ordering of items in getBuildConfiguration matters or not...
Comment on attachment 8971428 [details] [diff] [review]
patch

Review of attachment 8971428 [details] [diff] [review]:
-----------------------------------------------------------------

Seems straightforward enough. Looks good to me.
Attachment #8971428 - Flags: review?(jdemooij) → review+
Attached patch patch v2 — — Splinter Review 
Bringing over r+. This version sets the right commit message.
Attachment #8971428 - Attachment is obsolete: true
Attachment #8971445 - Flags: review+
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9515d63a7cf
Add coverage status to getBuildConfiguration, r=sfink
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d9515d63a7cf
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox61: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.