Closed Bug 1457327 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10669 - [css-tables] Scrollbar should be removed from OverrideLogicalHeight()

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10669 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10669
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-tables] Scrollbar should be removed from OverrideLogicalHeight()
>  
>  When computing the percentage height of table cell children,
>  if the table cell has horizontal scrollbar we have to subtract
>  its height from the OverrideLogicalHeight().
>  
>  The patch is just following a suggestion from a TODO in
>  LayoutBox::ComputePercentageLogicalHeight().
>  
>  BUG=837408
>  TEST=external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-002.html
>  
>  Change-Id: I5fc818545ce5ffcbb14112616f602668f492cc6d
>  Reviewed-on: https://chromium-review.googlesource.com/1031590
>  WPT-Export-Revision: d6d5dfa85c921959abf2d80070393ee3fac0e6f4
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
FAIL   : 1

New tests that have failures or other problems:
/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-002.html: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2853d00eeef8
[wpt PR 10669] - [css-tables] Scrollbar should be removed from OverrideLogicalHeight(), a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f54752992eb
[wpt PR 10669] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/2853d00eeef8
https://hg.mozilla.org/mozilla-central/rev/7f54752992eb
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.