Closed Bug 1457351 Opened 2 years ago Closed 2 years ago

color attribute has no effect on feFlood element.

Categories

(Core :: SVG, defect)

60 Branch
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: djg, Assigned: longsonr)

Details

Attachments

(2 files)

A `color="..."` attribute on <feFlood> element appears to have no effect (as shown in the attached sample).

Changing color attribute to `style="color: ..."`, successfully sets the color.
There's no such thing as a color attribute in SVG.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Actually no. The SVG resolved

a) not to add any new CSS properties as attributes in SVG 2 and
b) to add a color property per https://www.w3.org/TR/SVG2/painting.html#ColorProperty

Does any other browser support this property as an attribute?
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: INVALID → ---
We do support a color="" presentation attribute (it was one of the properties that was in SVG 1) but seemingly not on all elements.
We just missed it from one spot. I'm clearly not on form at the moment.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Both Chrome (66.0.3359.139) and Safari (11.1) accept `color="green"`
Assignee: nobody → longsonr
Attachment #8971455 - Flags: review?(cam)
(In reply to Dan Glastonbury (:kamidphish) | needinfo me from comment #5)
> Both Chrome (66.0.3359.139) and Safari (11.1) accept `color="green"`

Indeed, sorry about the mess here.
Comment on attachment 8971455 [details] [diff] [review]
map color in filters

Review of attachment 8971455 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks.  There is the broader issue of making (nearly) all presentation attributes available on all SVG namespaced elements, per https://svgwg.org/svg2-draft/styling.html#PresentationAttributes, but I'll file a separate bug about that.
Attachment #8971455 - Flags: review?(cam) → review+
Filed bug 1457360 for that.
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b0e963b050b
color attribute should apply to filters. r=heycam
https://hg.mozilla.org/mozilla-central/rev/4b0e963b050b
Status: NEW → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.