1457351 - color attribute has no effect on feFlood element.

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[u480271]

Attachment: svg-flood-color-attribute.html

A `color="..."` attribute on <feFlood> element appears to have no effect (as shown in the attached sample).

Changing color attribute to `style="color: ..."`, successfully sets the color.

Comment 1

[Robert Longson [:longsonr]]

There's no such thing as a color attribute in SVG.

Comment 2

[Robert Longson [:longsonr]]

Actually no. The SVG resolved

a) not to add any new CSS properties as attributes in SVG 2 and
b) to add a color property per https://www.w3.org/TR/SVG2/painting.html#ColorProperty

Does any other browser support this property as an attribute?

Comment 3

[Cameron McCormack (:heycam)]

We do support a color="" presentation attribute (it was one of the properties that was in SVG 1) but seemingly not on all elements.

Comment 4

[Robert Longson [:longsonr]]

We just missed it from one spot. I'm clearly not on form at the moment.

Comment 5

[u480271]

Both Chrome (66.0.3359.139) and Safari (11.1) accept `color="green"`

Comment 6

[Robert Longson [:longsonr]]

Attachment: map color in filters

Comment 7

[Robert Longson [:longsonr]]

(In reply to Dan Glastonbury (:kamidphish) | needinfo me from comment #5)
> Both Chrome (66.0.3359.139) and Safari (11.1) accept `color="green"`

Indeed, sorry about the mess here.

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8971455 [details] [diff] [review]
map color in filters

Review of attachment 8971455 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks.  There is the broader issue of making (nearly) all presentation attributes available on all SVG namespaced elements, per https://svgwg.org/svg2-draft/styling.html#PresentationAttributes, but I'll file a separate bug about that.

Comment 9

[Cameron McCormack (:heycam)]

Filed bug 1457360 for that.

Comment 10

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd52c113e07d8b9f9dcea6140244ce88aab33627

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b0e963b050b
color attribute should apply to filters. r=heycam

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4b0e963b050b