1457361 - MediaElementAudioCaptureOfMediaStreamError used but not defined

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

MediaElementAudioCaptureOfMediaStreamError is used as the name of an error string to report a stream capture warning here:

https://searchfox.org/mozilla-central/rev/78dbe34925f04975f16cb9a5d4938be714d41897/dom/html/HTMLMediaElement.cpp#3495

But it's not defined anywhere. So the logging statement here will have no effect. 

Someone should either remove that logging statement, or they should recreate the string.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

jib: Is this someone on your team's responsibility?

Comment 2

[Andreas Pehrson [:pehrsons]]

Good catch. It appears I missed to actually add the string back in the day. Sadly it got through review too.

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1457361 - Add the missing error string for MediaElementAudioSourceNode with MediaStream.

Review commit: https://reviewboard.mozilla.org/r/241734/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241734/

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8973277 [details]
Bug 1457361 - Add the missing error string for MediaElementAudioSourceNode with MediaStream.

https://reviewboard.mozilla.org/r/241734/#review247986

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22f9c6b26ccc
Add the missing error string for MediaElementAudioSourceNode with MediaStream. r=jib

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/22f9c6b26ccc