1457373 - Remove pref "layout.css.text-combine-upright-digits.enabled"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Spawned from bug 1417761 comment 3 by Xidorn:

> ::: modules/libpref/init/all.js:2902
> >  // Is support for CSS text-combine-upright: digits 2-4 enabled?
> >  pref("layout.css.text-combine-upright-digits.enabled", false);
> 
> This pref is no longer effective because stylo doesn't include this.
> Could you add a followup patch to remove this pref and any related code as well?

And bug 1417761 comment 6:

Gerald:
> No chance this may instead be re-implemented in Stylo one day?
Xidorn:
> Implementing the style part is easy, but the layout part is hard, so we are
> not going to revive its style part until we decide to work on the layout
> part.
> 
> Actually the usefulness of "digits" value as it's currently defined is
> unclear either, given it's easy to cause undesired result if not used
> carefully. Currently only Edge implemented that, and I don't think Chrome
> has plan for this at the moment either.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1457373 - Remove text-combine-upright digits option -

Review commit: https://reviewboard.mozilla.org/r/247184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247184/

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8981064 [details]
Bug 1457373 - Remove text-combine-upright digits option -

https://reviewboard.mozilla.org/r/247184/#review253394

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ecc66673444
Remove text-combine-upright digits option - r=xidorn

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8ecc66673444