1457477 - when loading Facebook messenger on messenger.com load animations stutter

Status: RESOLVED DUPLICATE of bug 1357487

(WebExtensions :: Request Handling, defect)

Description

[max_h]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180427102245

Steps to reproduce:

I loaded Facebook messenger from the messenger.com website (i am already logged in so it loads directly in to the overview of all my messages)


Actual results:

the webpage loads somewhat slowly and the load animation (dot that jumps back and forth to indicate loading) stops being smooth and stutters.


Expected results:

the webpage should have loaded with smooth load animations

Comment 1

[Daniel_A[:daschilean] [Please contact - [e-mail]]]

I verified this issue on Linux x86_64 with FF Nightly 61.0a1 (2018-05-01) and I cannot reproduce it.

Can you please create a video screen capture when you can and if you have time? To be sure that we understand the same steps to reproduce this issue. Thanks

Comment 2

[max_h]

Attachment: stutering load animation

Comment 3

[max_h]

when i disabled all my add-ons the animation seems to be smooth

Comment 4

[Daniel_A[:daschilean] [Please contact - [e-mail]]]

Based on Comment3 I see the issue is displayed because one of the active add-on. Could you please disable all the add-ons and after enable each one by one to see which one caused this issue? Thanks

Comment 5

[max_h]

When i enable 'voice fill' it starts slowing down, though not as consistently as i was seeing it. If i then additionally enable 'no script' it becomes more pronounced. (i am still seeing this behavior on the newest nightly)

Comment 6

[Daniel_A[:daschilean] [Please contact - [e-mail]]]

I manage to reproduce this issue on Ubuntu 16.04 with Firefox Nightly 62.0a1(2018-05-09) (64bit). I have the same results after enabling the add-ons from Comment5(voice fill, no script). Please note that this issue is also displayed on Windows 10 X64.

Comment 7

[Andrew Swan [:aswan]]

Can you capture a profile during this sequence?
There are some basic instructions at https://perf-html.io/

Comment 8

[max_h]

(In reply to Andrew Swan [:aswan] from comment #7)
> Can you capture a profile during this sequence?
> There are some basic instructions at https://perf-html.io/

Yes I can, do I have to worry about account information being present in the profile though and what should i do with it / where should i uploaded it

Comment 9

[Andrew Swan [:aswan]]

The profiler addon has a blurb about the kind of information included in a profile:
https://github.com/devtools-html/perf.html/blob/f61198098574e8552fd8c0632c76b5c2b72d5d7e/src/components/app/ProfileSharing.js#L40-L54

If you're okay with that, ideally upload to perf-html.io and then put the link into a comment here.

Comment 10

[max_h]

Vola, the profile you requested: https://perfht.ml/2GrkxXv (hope that's what you need)

Comment 11

[Andrew Swan [:aswan]]

It looks like you're on Linux, where extensions still run in the parent process.  And you have several extensions that use webRequest listeners installed (at least NoScript, Privacy Badger, and uBlock Origin).  At the same time, messenger.com is loading hundreds of resources.  I don't know if that's typical for messenger.com or a result of some interaction with the extensions you are using.

When we get extensions running in their own process on Linux, that should address the UI jitter issues you observed.  Other than that, I'm not sure there's not much we can do here, but Shane is more familiar with webRequest, perhaps he can take a look.

Comment 12

[Shane Caraveo (:mixedpuppy)]

I'd first be curious to know if turning on extensions.webextensions.remote in about:config fixes the problem.  If so, I'd just make this bug a blocker to bug 1357487.  

However, per comment 6 this also happens on windows, which already has that turned on.  On OSX I think I see some of what you're seeing, but even with the extensions disabled messenger is just slow for me.

Can you narrow it down to one extension that causes the largest amount of jank?  If so, I think I'd lean on the extension author to examine the performance of their extension.

Comment 14

[max_h]

(In reply to Shane Caraveo (:mixedpuppy) from comment #12)
> I'd first be curious to know if turning on extensions.webextensions.remote
> in about:config fixes the problem.  If so, I'd just make this bug a blocker
> to bug 1357487.  
> 
> However, per comment 6 this also happens on windows, which already has that
> turned on.  On OSX I think I see some of what you're seeing, but even with
> the extensions disabled messenger is just slow for me.
> 
> Can you narrow it down to one extension that causes the largest amount of
> jank?  If so, I think I'd lean on the extension author to examine the
> performance of their extension.

the extension that causes the most jank is NoScript for me,
turning on extensions.webextensions.remote does fix the problem though.

Comment 15

[Kris Maglione [:kmag]]

(In reply to max_h from comment #14)
> the extension that causes the most jank is NoScript for me,
> turning on extensions.webextensions.remote does fix the problem though.

That's pretty clear from the profile. It would be nice if NoScript added less overhead, but since most of that overhead should be in the extension process, at least it's not much of a responsiveness issue with OOP extensions enabled.