Closed
Bug 1457488
Opened 7 years ago
Closed 7 years ago
Improve error message with lower-case environment variable.
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
1.18 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•7 years ago
|
Attachment #8971605 -
Flags: review?(core-build-config-reviews)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → Ms2ger
Comment 1•7 years ago
|
||
Comment on attachment 8971605 [details] [diff] [review]
Patch
Review of attachment 8971605 [details] [diff] [review]:
-----------------------------------------------------------------
::: python/mozbuild/mozbuild/configure/options.py
@@ +275,5 @@
> raise InvalidOptionError(
> 'Option must start with two dashes instead of one')
> if name.islower():
> raise InvalidOptionError(
> + 'Environment variable name %s must be all uppercase' % name)
Might put some quotes around the name ('...name "%s" must...' % name) as well.
Attachment #8971605 -
Flags: review?(core-build-config-reviews) → review+
Pushed by Ms2ger@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/193ffb14b691
Improve error message with lower-case environment variable; r=chmanchester
Comment 3•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•