1457488 - Improve error message with lower-case environment variable.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8971605 [details] [diff] [review]
Patch

Review of attachment 8971605 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/configure/options.py
@@ +275,5 @@
>                  raise InvalidOptionError(
>                      'Option must start with two dashes instead of one')
>              if name.islower():
>                  raise InvalidOptionError(
> +                    'Environment variable name %s must be all uppercase' % name)

Might put some quotes around the name ('...name "%s" must...' % name) as well.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/193ffb14b691
Improve error message with lower-case environment variable; r=chmanchester

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/193ffb14b691