Closed Bug 1457488 Opened 7 years ago Closed 7 years ago

Improve error message with lower-case environment variable.

Categories

(Firefox Build System :: General, enhancement)

3 Branch
enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #8971605 - Flags: review?(core-build-config-reviews)
Assignee: nobody → Ms2ger
Comment on attachment 8971605 [details] [diff] [review] Patch Review of attachment 8971605 [details] [diff] [review]: ----------------------------------------------------------------- ::: python/mozbuild/mozbuild/configure/options.py @@ +275,5 @@ > raise InvalidOptionError( > 'Option must start with two dashes instead of one') > if name.islower(): > raise InvalidOptionError( > + 'Environment variable name %s must be all uppercase' % name) Might put some quotes around the name ('...name "%s" must...' % name) as well.
Attachment #8971605 - Flags: review?(core-build-config-reviews) → review+
Pushed by Ms2ger@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/193ffb14b691 Improve error message with lower-case environment variable; r=chmanchester
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: