1457489 - Phabricator revisions missing cell borders in "Reviews Request of You"

Status: RESOLVED INVALID

(bugzilla.mozilla.org :: MyDashboard, defect)

Description

[Steven MacLeod [:smacleod]]

Attachment: Screenshot from 2018-04-27 11-22-12.png

See screenshot.

Comment 1

[:glob ✱]

each entry is two rows, with the top row holding the commit summary spanning all columns.
this is clearer when longer summaries are used; i'll attach a screenshot.

Comment 2

[:glob ✱]

Attachment: Screenshot 2018-04-30 11.39.43.png

Comment 3

[Steven MacLeod [:smacleod]]

(In reply to Byron Jones ‹:glob› from comment #2)
> Created attachment 8971926 [details]
> Screenshot 2018-04-30 11.39.43.png

maybe it should be centered? This still looks really strange to me.

Comment 4

[:glob ✱]

i agree it looks odd, however all other cells on that page are left aligned.

there's plans to redo the my-dashboard page (currently it's one of a tiny number of bmo pages that use yui3), so this can be tidied up then.  (although the whole dashboard page does look nice without any of the vertical borders).

Comment 5

[Steven MacLeod [:smacleod]]

(In reply to Byron Jones ‹:glob› from comment #4)
> (although the whole dashboard page does look nice without any of the
> vertical borders).

This seems like a nice easy fix, I'd vote for going that direction unless there's a compelling reason not to.