Closed Bug 1457505 Opened Last year Closed Last year

Variation fonts are force-disabled in current Nightly on Windows

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

This was a regression introduced by bug 1454598 part 4. The platform's CheckVariationFontSupport() method is now called early in gfxPlatform initialization; in particular, it is before gfxPlatformFontList setup. Therefore, the mUsingDirectWrite flag is always false, and the check always fails.

To resolve this, we should just check the Windows version here. Then, during font-list setup, if we end up using GDI fonts, we can force the platform flag to false at that time.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8971640 - Flags: review?(lsalzman)
Attachment #8971640 - Flags: review?(lsalzman) → review+
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fb52e3bc8af
Fix the check for variation-font support in gfxWindowsPlatform: cannot depend on checking mUsingDirectWrite, as the fontlist is not yet set up. r=lsalzman
https://hg.mozilla.org/mozilla-central/rev/1fb52e3bc8af
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.