1457505 - Variation fonts are force-disabled in current Nightly on Windows

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew [:jfkthame]]

This was a regression introduced by bug 1454598 part 4. The platform's CheckVariationFontSupport() method is now called early in gfxPlatform initialization; in particular, it is before gfxPlatformFontList setup. Therefore, the mUsingDirectWrite flag is always false, and the check always fails.

To resolve this, we should just check the Windows version here. Then, during font-list setup, if we end up using GDI fonts, we can force the platform flag to false at that time.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Fix the check for variation-font support in gfxWindowsPlatform; cannot depend on mUsingDirectWrite, as the fontlist is not yet set up

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fb52e3bc8af
Fix the check for variation-font support in gfxWindowsPlatform: cannot depend on checking mUsingDirectWrite, as the fontlist is not yet set up. r=lsalzman

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1fb52e3bc8af