Closed Bug 1457523 Opened 2 years ago Closed 2 years ago

Windows ASan test machines are missing msdia140.dll

Categories

(Firefox Build System :: General, defect)

3 Branch
defect
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

Windows ASan failures currently have garbage stacks because llvm-symbolizer.exe can't find a copy of msdia140.dll.

17:33:10     INFO -  GECKO(4468) | WRITE of size 4 at 0x12d64f8007e0 thread T0
17:33:10     INFO -  GECKO(4468) |     #0 0x7fff33ee283a  (C:\Users\task_1524847483\AppData\Local\Temp\tmp9grbql.mozrunner\plugins\nptest.dll+0x18001283a)
17:33:10     INFO -  GECKO(4468) |     #1 0x7fff33ee2dc2  (C:\Users\task_1524847483\AppData\Local\Temp\tmp9grbql.mozrunner\plugins\nptest.dll+0x180012dc2)
17:33:10     INFO -  GECKO(4468) |     #2 0x7fff47aebc4f  (C:\Windows\System32\user32.dll+0x18000bc4f)
17:33:10     INFO -  GECKO(4468) |     #3 0x7fff47aeb94b  (C:\Windows\System32\user32.dll+0x18000b94b)
17:33:10     INFO -  GECKO(4468) |     #4 0x7fff47b03e7f  (C:\Windows\System32\user32.dll+0x180023e7f)
17:33:10     INFO -  GECKO(4468) |     #5 0x7fff48f290b3  (C:\Windows\SYSTEM32\ntdll.dll+0x1800a90b3)
17:33:10     INFO -  GECKO(4468) |     #6 0x1328520f23c3  (C:\Windows\System32\win32u.dll+0x1800023c3)
17:33:11     INFO -  GECKO(4468) |     #7 0x7fff1a6ba74a  (Z:\task_1524847483\build\application\firefox\xul.dll+0x18828a74a)
17:33:11     INFO -  GECKO(4468) |     #8 0x7fff1a6bb416  (Z:\task_1524847483\build\application\firefox\xul.dll+0x18828b416)
Comment on attachment 8971677 [details] [diff] [review]
Bug 1457523: Add msdia140.dll to the package on Windows ASan CI builds.

Review of attachment 8971677 [details] [diff] [review]:
-----------------------------------------------------------------

::: old-configure.in
@@ +232,5 @@
> +        if test -n "$WIN_DIA_SDK_BIN_DIR"; then
> +          if test ! -d "$WIN_DIA_SDK_BIN_DIR"; then
> +            AC_MSG_ERROR([Invalid Windows DIA SDK directory: ${WIN_DIA_SDK_BIN_DIR}])
> +          fi
> +          WIN_DIA_SDK_BIN_DIR=`cd "$WIN_DIA_SDK_BIN_DIR" && pwd -W`

I don't love adding new things to old-configure.in, but I understand that you copied this from the bits above and moving it to moz.configure is nontrivial for people that aren't very familiar with it, so I can live with this.
Attachment #8971677 - Flags: review?(ted) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f099a327258
Add msdia140.dll to the package on Windows ASan CI builds. r=ted
https://hg.mozilla.org/mozilla-central/rev/9f099a327258
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.