1457622 - Linting errors: calendar/base/modules/utils/calCategoryUtils.jsm:75:63 | Unexpected control character(s) in regular expression: \x1a. (no-control-regex)

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1457064 +++

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/base/modules/utils/calCategoryUtils.jsm:75:63 | Unexpected control character(s) in regular expression: \x1a. (no-control-regex)

Comment 1

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

The usage of a control character is perfectly valid in this case, so I just disabled the eslint rule for those lines.

Comment 2

[Jorg K (CEST = GMT+2)]

That's what I thought. Thanks.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8971766 [details] [diff] [review]
Patch v1

Review of attachment 8971766 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/modules/utils/calCategoryUtils.jsm
@@ +69,5 @@
>      stringToArray: function(aCategories) {
>          if (!aCategories) {
>              return [];
>          }
> +        /* eslint-disable no-control-regex */

I'd suggest to use

// eslint-disable-next-line no-control-regex

one liner lower. Good either way though.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cd078ad0eca4
Linting errors: calendar/base/modules/utils/calCategoryUtils.jsm:75:63 | Unexpected control character(s) in regular expression: \x1a. (no-control-regex). r=philipp

Comment 5

[Jorg K (CEST = GMT+2)]

Beta (TB 60 beta 6, Calendar 6.2):
https://hg.mozilla.org/releases/comm-beta/rev/716b72efa5eb590a0c8a0f78e5474749bd0ec4bc