Linting errors: calendar/base/modules/utils/calCategoryUtils.jsm:75:63 | Unexpected control character(s) in regular expression: \x1a. (no-control-regex)

RESOLVED FIXED in 6.2

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: jorgk, Assigned: martinschroeder)

Tracking

Trunk

Details

Attachments

(1 attachment)

Reporter

Description

Last year
+++ This bug was initially created as a clone of Bug #1457064 +++

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/base/modules/utils/calCategoryUtils.jsm:75:63 | Unexpected control character(s) in regular expression: \x1a. (no-control-regex)
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
Posted patch Patch v1Splinter Review
The usage of a control character is perfectly valid in this case, so I just disabled the eslint rule for those lines.
Attachment #8971766 - Flags: review?(philipp)
Attachment #8971766 - Flags: approval-calendar-beta?(philipp)
Reporter

Comment 2

Last year
That's what I thought. Thanks.
Comment on attachment 8971766 [details] [diff] [review]
Patch v1

Review of attachment 8971766 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/modules/utils/calCategoryUtils.jsm
@@ +69,5 @@
>      stringToArray: function(aCategories) {
>          if (!aCategories) {
>              return [];
>          }
> +        /* eslint-disable no-control-regex */

I'd suggest to use

// eslint-disable-next-line no-control-regex

one liner lower. Good either way though.
Attachment #8971766 - Flags: review?(philipp)
Attachment #8971766 - Flags: review+
Attachment #8971766 - Flags: approval-calendar-beta?(philipp)
Attachment #8971766 - Flags: approval-calendar-beta+

Comment 4

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/cd078ad0eca4
Linting errors: calendar/base/modules/utils/calCategoryUtils.jsm:75:63 | Unexpected control character(s) in regular expression: \x1a. (no-control-regex). r=philipp
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Reporter

Updated

Last year
Target Milestone: --- → 6.3
Reporter

Comment 5

Last year
Beta (TB 60 beta 6, Calendar 6.2):
https://hg.mozilla.org/releases/comm-beta/rev/716b72efa5eb590a0c8a0f78e5474749bd0ec4bc
Target Milestone: 6.3 → 6.2
You need to log in before you can comment on or make changes to this bug.