Closed Bug 1457652 Opened Last year Closed Last year

Incorrect serialization order for outline

Categories

(Core :: CSS Parsing and Computation, defect)

59 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: ericwilligers, Assigned: emilio)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce:

https://jsfiddle.net/ericwilligers/6641mLdf/
Set the inline style of 'outline' to '3px ridge rgba(10, 20, 30, 0.4)'
Read the inline style.



Actual results:

The inline style is  '3px ridge rgba(10, 20, 30, 0.4)'


Expected results:

The inline style should be 'rgba(10, 20, 30, 0.4) ridge 3px'

https://drafts.csswg.org/css-ui-3/#outline
[ <outline-color> || <outline-style> || <outline-width> ]
FWIW if you file bugs under the "CSS Parsing and Computation" component we find them much faster :P
Component: Untriaged → CSS Parsing and Computation
Product: Firefox → Core
Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8971762 [details]
Bug 1457652: Fix serialization order of the outline shorthand.

https://reviewboard.mozilla.org/r/240530/#review246258
Attachment #8971762 - Flags: review?(xidorn+moz) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a03e9effe84
Fix serialization order of the outline shorthand. r=xidorn
Backed out changeset 2a03e9effe84 (bug 1457652) for WPT failures on /css/cssom/shorthand-values.html

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=176108195&repo=autoland&lineNumber=2352

INFO - TEST-PASS | /css/cssom/shorthand-values.html | The serialization of overflow-x: scroll; overflow-y: scroll; should be canonical. 
[task 2018-04-28T10:59:35.612Z] 10:59:35     INFO - TEST-UNEXPECTED-PASS | /css/cssom/shorthand-values.html | The serialization of outline-width: 2px; outline-style: dotted; outline-color: blue; should be canonical. - expected FAIL
[task 2018-04-28T10:59:35.612Z] 10:59:35     INFO - TEST-INFO | expected FAIL
[task 2018-04-28T10:59:35.616Z] 10:59:35     INFO - .....
[task 2018-04-28T10:59:35.617Z] 10:59:35     INFO - TEST-OK | /css/cssom/shorthand-values.html | took 219ms
[task 2018-04-28T10:59:35.725Z] 10:59:35     INFO - PID 3691 | JavaScript error: resource:///modules/AsyncTabSwitcher.jsm, line 248: TypeError: browser.frameLoader is null
[task 2018-04-28T10:59:35.802Z] 10:59:35     INFO - PID 3691 | *** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping
[task 2018-04-28T10:59:36.161Z] 10:59:36     INFO - Browser exited with return code 0
[task 2018-04-28T10:59:36.162Z] 10:59:36  WARNING - u'runner_teardown': ()
[task 2018-04-28T10:59:36.170Z] 10:59:36     INFO - Setting up ssl
[task 2018-04-28T10:59:36.207Z] 10:59:36     INFO - certutil | 
[task 2018-04-28T10:59:36.235Z] 10:59:36     INFO - certutil | 
[task 2018-04-28T10:59:36.255Z] 10:59:36     INFO - certutil | 
[task 2018-04-28T10:59:36.256Z] 10:59:36     INFO - Certificate Nickname                                         Trust Attributes
[task 2018-04-28T10:59:36.256Z] 10:59:36     INFO -                                                              SSL,S/MIME,JAR/XPI
[task 2018-04-28T10:59:36.256Z] 10:59:36     INFO - 
[task 2018-04-28T10:59:36.257Z] 10:59:36     INFO - web-platform-tests                                           CT,, 
[task 2018-04-28T10:59:36.257Z] 10:59:36     INFO - 
[task 2018-04-28T10:59:36.273Z] 10:59:36     INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmpDWfsXQ.mozrunner
[task 2018-04-28T10:59:36.289Z] 10:59:36     INFO - Starting runner
[task 2018-04-28T10:59:38.714Z] 10:59:38     INFO - PID 3989 | 1524913178710	Marionette	INFO	Listening on port 2828
[task 2018-04-28T10:59:38.969Z] 10:59:38     INFO - TEST-START | /css/cssom/style-sheet-interfaces-001.html
[task 2018-04-28T10:59:39.392Z] 10:59:39     INFO - ......
[task 2018-04-28T10:59:39.392Z] 10:59:39     INFO - TEST-OK | /css/cssom/style-sheet-interfaces-001.html | took 417ms

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2a03e9effe84d574a0dfdaaefd9bde2f69df6d0e

Backout:
https://hg.mozilla.org/integration/autoland/rev/8fc6c9d1bfa207883fd6095189bd722f719f2056
Flags: needinfo?(emilio)
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/807e94988d9a
Fix serialization order of the outline shorthand. r=xidorn
Ahh, sorry. Apparently there were already tests for this.

FWIW when there's only a unexpected pass like this one I can fix it up after-the-fact if you tell me.

Relanded with a test update.
Flags: needinfo?(emilio)
https://hg.mozilla.org/mozilla-central/rev/807e94988d9a
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
See Also: → 1457744
You need to log in before you can comment on or make changes to this bug.