1457689 - document.domain throws wrong exception

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Anne (:annevk)]

Should be "SecurityError" DOMException, not NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN.

Test: https://github.com/w3c/web-platform-tests/pull/10703.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1457689 - Fix documain.domain setting exception type;

Change exception type to comply with HTML spec, which uses security
error instead of bad document domain.

Review commit: https://reviewboard.mozilla.org/r/250124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250124/

Comment 2

[Anne (:annevk)]

Comment on attachment 8984316 [details]
Bug 1457689 - Fix documain.domain setting exception type;

https://reviewboard.mozilla.org/r/250124/#review256444

You might have to get r+ from an actual reviewer too.

Comment 3

[Anne (:annevk)]

Hmm, so given https://searchfox.org/mozilla-central/search?q=NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN it seems there's one more occurrence that should be changed (and isn't tested for?) and then the whole exception can be removed.

Comment 4

[Anne (:annevk)]

Comment on attachment 8984316 [details]
Bug 1457689 - Fix documain.domain setting exception type;

https://reviewboard.mozilla.org/r/250124/#review256446

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Ah, ok, thanks! I'll get that cleaned up and bring in bz for reviews.

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1457689 - Remove NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN;

After fixing the document.domain exceptions to conform to the html
spec, NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN is no longer used, and can be
removed.

Review commit: https://reviewboard.mozilla.org/r/250508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250508/

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8984316 [details]
Bug 1457689 - Fix documain.domain setting exception type;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250124/diff/1-2/

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8984316 [details]
Bug 1457689 - Fix documain.domain setting exception type;

https://reviewboard.mozilla.org/r/250124/#review256812

r=me

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8984612 [details]
Bug 1457689 - Remove NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN;

https://reviewboard.mozilla.org/r/250508/#review256814

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe5ded10511f
Fix documain.domain setting exception type; r=bz
https://hg.mozilla.org/integration/autoland/rev/16606407297e
Remove NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN; r=bz

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fe5ded10511f
https://hg.mozilla.org/mozilla-central/rev/16606407297e

Comment 12

[Chris Mills [:cmills]]

We don't do a good job of documenting this property. We should document this and any other exceptions it throws properly, and generally give the doc an update.

Comment 13

[Chris Mills [:cmills]]

I have given the ref doc a damn good spring clean:

https://developer.mozilla.org/en-US/docs/Web/API/Document/domain

Not sure if it worth mentioning the actual change this bug makes in the rel notes, so I've left it for now.