Closed Bug 1457744 Opened 5 years ago Closed 5 years ago

Fix serialization order of the list-style shorthand.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: emilio, Unassigned)

References

Details

Attachments

(1 file)

      No description provided.
Comment on attachment 8971840 [details]
Bug 1457744: Fix serialization order of list-style.

https://reviewboard.mozilla.org/r/240584/#review246276

The spec is probably wrong here. `list-style-type` accepts arbitrary identifier, which can overlap with values of `list-style-position`, and thus it is checked at last. Serializing it first means we may get different result in some case.

Please consider declaration like `list-style: inside outside;`. It currently means `list-style-position: inside; list-style-type: outside;` because `list-style-type` is parsed later, but this change would make us serialize it as `list-style: outside inside;` which changes the original meaning.

We should change the canonical order of `list-style` to make `list-style-type` the last one, just like what we've done with `animation` shorthand.
Attachment #8971840 - Flags: review?(xidorn+moz)
Hmm, indeed. Good point. Filed https://github.com/w3c/csswg-drafts/issues/2624.
Assignee: emilio → nobody
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.