Closed Bug 1457782 Opened 2 years ago Closed Last year

Use help.svg instead of Question.png on Windows

Categories

(Toolkit :: Themes, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ntim, Assigned: vcote)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files, 2 obsolete files)

See: https://searchfox.org/mozilla-central/search?q=Question.png&case=true&regexp=false&path=

chrome://global/skin/icons/Question.png can be replaced with chrome://global/skin/icons/help.svg
Priority: -- → P3
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1457782 (obsolete) — Splinter Review
Please review.
Flags: needinfo?(ntim.bugs)
It looks like you forgot to delete the actual Question.png file in the patch.
Flags: needinfo?(ntim.bugs) → needinfo?(1991manish.kumar)
Attached patch PatchNew_Bug1457782 (obsolete) — Splinter Review
Attachment #8982491 - Attachment is obsolete: true
Flags: needinfo?(1991manish.kumar) → needinfo?(ntim.bugs)
Flags: needinfo?(ntim.bugs)
Attachment #8982501 - Flags: review?(dao+bmo)
Comment on attachment 8982501 [details] [diff] [review]
PatchNew_Bug1457782

>--- a/toolkit/themes/windows/global/jar.mn
>+++ b/toolkit/themes/windows/global/jar.mn
>@@ -49,7 +49,7 @@ toolkit.jar:
>   skin/classic/global/icons/Portrait.png                   (icons/Portrait.png)
>   skin/classic/global/icons/Print-preview.png              (icons/Print-preview.png)
>   skin/classic/global/icons/Search-close.png               (icons/Search-close.png)
>-  skin/classic/global/icons/Question.png                   (icons/Question.png)
>+  skin/classic/global/icons/help.svg                       (icons/help.svg)

This file doesn't exist, does it? help.svg is already packaged here:
https://searchfox.org/mozilla-central/rev/3737701cfab93ccea04c0e9cab211ad10f931d87/toolkit/themes/shared/jar.inc.mn#37
Attachment #8982501 - Flags: review?(dao+bmo) → review-
So much confusion with these kinds of bugs. 

Any issue with patch here?
Flags: needinfo?(ntim.bugs)
(In reply to Manish Kumar [:manishkk] from comment #5)
> So much confusion with these kinds of bugs. 
> 
> Any issue with patch here?

help.svg is already included in shared/jar.inc.mn, so you don't need to include help.svg in windows/jar.mn.
Flags: needinfo?(ntim.bugs)
Please review.
Attachment #8982501 - Attachment is obsolete: true
Flags: needinfo?(ntim.bugs)
You still need to remove the jar.mn line for Question.png on Windows :) 

https://searchfox.org/mozilla-central/source/toolkit/themes/windows/global/jar.mn#52
Flags: needinfo?(ntim.bugs)
Oh wait, you're already doing that in bug 1457781, so let's wait for that bug to land instead :)
Assignee: 1991manish.kumar → nobody
Keywords: good-first-bug
Blocks: 1493190
Comment on attachment 9011124 [details]
Bug 1457782 - Use help.svg instead of Question.png on Windows. r?dao

Dão Gottwald [::dao] has approved the revision.
Attachment #9011124 - Flags: review+
Assignee: nobody → vincent.cote
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17b842daa4fa
Use help.svg instead of Question.png on Windows. r=dao
Status: NEW → ASSIGNED
Priority: P3 → P1
https://hg.mozilla.org/mozilla-central/rev/17b842daa4fa
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.