Closed Bug 1457782 Opened 2 years ago Closed Last year
.svg instead of Question .png on Windows
See: https://searchfox.org/mozilla-central/search?q=Question.png&case=true®exp=false&path= chrome://global/skin/icons/Question.png can be replaced with chrome://global/skin/icons/help.svg
It looks like you forgot to delete the actual Question.png file in the patch.
Flags: needinfo?(ntim.bugs) → needinfo?(1991manish.kumar)
Attachment #8982491 - Attachment is obsolete: true
Flags: needinfo?(1991manish.kumar) → needinfo?(ntim.bugs)
Attachment #8982501 - Flags: review?(dao+bmo)
Comment on attachment 8982501 [details] [diff] [review] PatchNew_Bug1457782 >--- a/toolkit/themes/windows/global/jar.mn >+++ b/toolkit/themes/windows/global/jar.mn >@@ -49,7 +49,7 @@ toolkit.jar: > skin/classic/global/icons/Portrait.png (icons/Portrait.png) > skin/classic/global/icons/Print-preview.png (icons/Print-preview.png) > skin/classic/global/icons/Search-close.png (icons/Search-close.png) >- skin/classic/global/icons/Question.png (icons/Question.png) >+ skin/classic/global/icons/help.svg (icons/help.svg) This file doesn't exist, does it? help.svg is already packaged here: https://searchfox.org/mozilla-central/rev/3737701cfab93ccea04c0e9cab211ad10f931d87/toolkit/themes/shared/jar.inc.mn#37
Attachment #8982501 - Flags: review?(dao+bmo) → review-
So much confusion with these kinds of bugs. Any issue with patch here?
(In reply to Manish Kumar [:manishkk] from comment #5) > So much confusion with these kinds of bugs. > > Any issue with patch here? help.svg is already included in shared/jar.inc.mn, so you don't need to include help.svg in windows/jar.mn.
Attachment #8982501 - Attachment is obsolete: true
You still need to remove the jar.mn line for Question.png on Windows :) https://searchfox.org/mozilla-central/source/toolkit/themes/windows/global/jar.mn#52
Oh wait, you're already doing that in bug 1457781, so let's wait for that bug to land instead :)
Comment on attachment 9011124 [details] Bug 1457782 - Use help.svg instead of Question.png on Windows. r?dao Dão Gottwald [::dao] has approved the revision.
Attachment #9011124 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/17b842daa4fa Use help.svg instead of Question.png on Windows. r=dao
You need to log in before you can comment on or make changes to this bug.