1457784 - Use warning.svg instead of warning-16.png

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P3)

Description

[Tim Nguyen :ntim]

What can be removed:

toolkit/themes/osx/global/icons/warning-16.png
toolkit/themes/windows/global/icons/warning-16.png
https://searchfox.org/mozilla-central/source/browser/themes/linux/jar.mn#7
https://searchfox.org/mozilla-central/source/toolkit/themes/osx/global/jar.mn#65
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/non-mac.jar.inc.mn#30


The rest on this list: https://searchfox.org/mozilla-central/search?q=warning-16.png&case=true&regexp=false&path=

should be replaced with chrome://global/skin/icons/warning.svg

Comment 1

[Manish [:manishkk]]

'warning.svg' doesn't exist.
https://dxr.mozilla.org/mozilla-central/search?q=%2FWarning.svg&redirect=false

Comment 2

[Tim Nguyen :ntim]

You can use the `path:` prefix to show file matches: https://dxr.mozilla.org/mozilla-central/search?q=path%3Awarning.svg&redirect=false

Comment 3

[Arshad Kazmi [:arshadkazmi42]]

Is it still open? I am interested to take this up

Comment 4

[Tim Nguyen :ntim]

(In reply to Arshad Kazmi [:arshadkazmi42] from comment #3)
> Is it still open? I am interested to take this up

Sure, please let me know if you have any questions.

Comment 5

[Arshad Kazmi [:arshadkazmi42]]

so just to clarify as per Comment 1

I have to remove these

toolkit/themes/osx/global/icons/warning-16.png
toolkit/themes/windows/global/icons/warning-16.png
https://searchfox.org/mozilla-central/source/browser/themes/linux/jar.mn#7
https://searchfox.org/mozilla-central/source/toolkit/themes/osx/global/jar.mn#65
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/non-mac.jar.inc.mn#30


and replace everything in this list

The rest on this list: https://searchfox.org/mozilla-central/search?q=warning-16.png&case=true&regexp=false&path=

Comment 6

[Tim Nguyen :ntim]

Two of the links above have slightly changed (the line numbers):

https://searchfox.org/mozilla-central/source/toolkit/themes/shared/non-mac.jar.inc.mn#29
https://searchfox.org/mozilla-central/source/toolkit/themes/osx/global/jar.mn#64

But yeah, everything else is correct.

Comment 7

[Arshad Kazmi [:arshadkazmi42]]

DO i need to verify any tests after this change?

Comment 8

[Tim Nguyen :ntim]

(In reply to Arshad Kazmi [:arshadkazmi42] from comment #7)
> DO i need to verify any tests after this change?

You'll need to manually check if:
- about:neterror
- about:library
- about:sessionrestore

still have a warning icon as page favicon.

Comment 9

[Arshad Kazmi [:arshadkazmi42]]

Attachment: Bug 1457784 - Replace warning-16.png with warning.svg. r=dao

replace warning icon to svg icon in aboutNetError-new.xhtml

warning-16.png removed from osx and global themes

Comment 10

[Arshad Kazmi [:arshadkazmi42]]

Hey Tim,
I am done with the changes and verified the favicon manually.

Whom should I add as reviewer in phabricator?

Comment 11

[Tim Nguyen :ntim]

Reviewed. Thanks for working on this!

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 9009453 [details]
Bug 1457784 - Replace warning-16.png with warning.svg. r=dao

Dão Gottwald [::dao] has approved the revision.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ac589d31bd7
Replace warning-16.png with warning.svg. r=dao

Comment 14

[Arshad Kazmi [:arshadkazmi42]]

Thanks for the review dao.
Do I need to add check-in needed flag here?

Looks like code is already pushed.

Comment 15

[Dão Gottwald [:dao]]

Yep, already pushed.

Comment 16

[Arshad Kazmi [:arshadkazmi42]]

Ok. thanks :)

Comment 17

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4ac589d31bd7