Closed Bug 1457784 Opened 3 years ago Closed 2 years ago

Use warning.svg instead of warning-16.png

Categories

(Toolkit :: Themes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ntim, Assigned: arshadkazmi42, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Priority: -- → P3
Assignee: nobody → 1991manish.kumar
You can use the `path:` prefix to show file matches: https://dxr.mozilla.org/mozilla-central/search?q=path%3Awarning.svg&redirect=false
Flags: needinfo?(ntim.bugs)
Assignee: 1991manish.kumar → nobody
Mentor: ntim.bugs
Keywords: good-first-bug
Is it still open? I am interested to take this up
Flags: needinfo?(ntim.bugs)
(In reply to Arshad Kazmi [:arshadkazmi42] from comment #3)
> Is it still open? I am interested to take this up

Sure, please let me know if you have any questions.
Assignee: nobody → arshadkazmi42
Flags: needinfo?(ntim.bugs)
so just to clarify as per Comment 1

I have to remove these

toolkit/themes/osx/global/icons/warning-16.png
toolkit/themes/windows/global/icons/warning-16.png
https://searchfox.org/mozilla-central/source/browser/themes/linux/jar.mn#7
https://searchfox.org/mozilla-central/source/toolkit/themes/osx/global/jar.mn#65
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/non-mac.jar.inc.mn#30


and replace everything in this list

The rest on this list: https://searchfox.org/mozilla-central/search?q=warning-16.png&case=true&regexp=false&path=
Flags: needinfo?(ntim.bugs)
Two of the links above have slightly changed (the line numbers):

https://searchfox.org/mozilla-central/source/toolkit/themes/shared/non-mac.jar.inc.mn#29
https://searchfox.org/mozilla-central/source/toolkit/themes/osx/global/jar.mn#64

But yeah, everything else is correct.
Flags: needinfo?(ntim.bugs)
DO i need to verify any tests after this change?
Flags: needinfo?(ntim.bugs)
(In reply to Arshad Kazmi [:arshadkazmi42] from comment #7)
> DO i need to verify any tests after this change?

You'll need to manually check if:
- about:neterror
- about:library
- about:sessionrestore

still have a warning icon as page favicon.
Flags: needinfo?(ntim.bugs)
replace warning icon to svg icon in aboutNetError-new.xhtml

warning-16.png removed from osx and global themes
Hey Tim,
I am done with the changes and verified the favicon manually.

Whom should I add as reviewer in phabricator?
Flags: needinfo?(ntim.bugs)
Reviewed. Thanks for working on this!
Flags: needinfo?(ntim.bugs)
Comment on attachment 9009453 [details]
Bug 1457784 - Replace warning-16.png with warning.svg. r=dao

Dão Gottwald [::dao] has approved the revision.
Attachment #9009453 - Flags: review+
Attachment #9009453 - Attachment description: Bug 1457784 - warning-16.png replaced with warning.svg → Bug 1457784 - Replace warning-16.png with warning.svg.
Attachment #9009453 - Attachment description: Bug 1457784 - Replace warning-16.png with warning.svg. → Bug 1457784 - Replace warning-16.png with warning.svg. r=dao
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ac589d31bd7
Replace warning-16.png with warning.svg. r=dao
Thanks for the review dao.
Do I need to add check-in needed flag here?

Looks like code is already pushed.
Flags: needinfo?(dao+bmo)
Yep, already pushed.
Flags: needinfo?(dao+bmo)
Ok. thanks :)
https://hg.mozilla.org/mozilla-central/rev/4ac589d31bd7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.